On Sun, Jul 29, 2007 at 09:03:29PM +0800, Eugene Teo wrote:
> Neil Horman wrote:
> [...]
> > + /* core limit size */
> > + case 'c':
> > + rc = snprintf(out_ptr, out_end - out_ptr,
> > + "%lu",
>
Neil Horman wrote:
[...]
> + /* core limit size */
> + case 'c':
> + rc = snprintf(out_ptr, out_end - out_ptr,
> + "%lu",
> current->signal->rlim[RLIMIT_CORE].rlim_cur);
Trailing space.
On Sun, Jul 29, 2007 at 11:34:18AM +0200, Martin Pitt wrote:
> Hi Neil,
>
> Neil Horman [2007-07-28 13:21 -0400]:
> > Jeremy asked that I make a patch next week to address split_argv's
> > requirement
> > that the argc parameter be non-NULL. I'll be fixing that next week, and
> > what I
> >
On Sun, Jul 29, 2007 at 02:23:10PM +0530, Aneesh Kumar K.V wrote:
>
>
> Neil Horman wrote:
> >On Sat, Jul 28, 2007 at 06:17:25PM +0200, Martin Pitt wrote:
> >>Hi Neil,
> >>
> >>Neil Horman [2007-07-28 9:46 -0400]:
> I just want to mention a potential problem with this: If you first
>
Hi Neil,
Neil Horman [2007-07-28 13:21 -0400]:
> Jeremy asked that I make a patch next week to address split_argv's requirement
> that the argc parameter be non-NULL. I'll be fixing that next week, and what
> I
> can do is further enhance it such that it ignores spaces in quoted strings,
>
Neil Horman wrote:
On Sat, Jul 28, 2007 at 06:17:25PM +0200, Martin Pitt wrote:
Hi Neil,
Neil Horman [2007-07-28 9:46 -0400]:
I just want to mention a potential problem with this: If you first
expand the macros (from pattern to corename) and then split
corename into an argv, then this
Neil Horman wrote:
On Sat, Jul 28, 2007 at 06:17:25PM +0200, Martin Pitt wrote:
Hi Neil,
Neil Horman [2007-07-28 9:46 -0400]:
I just want to mention a potential problem with this: If you first
expand the macros (from pattern to corename) and then split
corename into an argv, then this
Hi Neil,
Neil Horman [2007-07-28 13:21 -0400]:
Jeremy asked that I make a patch next week to address split_argv's requirement
that the argc parameter be non-NULL. I'll be fixing that next week, and what
I
can do is further enhance it such that it ignores spaces in quoted strings,
which
On Sun, Jul 29, 2007 at 02:23:10PM +0530, Aneesh Kumar K.V wrote:
Neil Horman wrote:
On Sat, Jul 28, 2007 at 06:17:25PM +0200, Martin Pitt wrote:
Hi Neil,
Neil Horman [2007-07-28 9:46 -0400]:
I just want to mention a potential problem with this: If you first
expand the macros (from
On Sun, Jul 29, 2007 at 11:34:18AM +0200, Martin Pitt wrote:
Hi Neil,
Neil Horman [2007-07-28 13:21 -0400]:
Jeremy asked that I make a patch next week to address split_argv's
requirement
that the argc parameter be non-NULL. I'll be fixing that next week, and
what I
can do is
Neil Horman wrote:
[...]
+ /* core limit size */
+ case 'c':
+ rc = snprintf(out_ptr, out_end - out_ptr,
+ %lu,
current-signal-rlim[RLIMIT_CORE].rlim_cur);
Trailing space.
[...]
On Sun, Jul 29, 2007 at 09:03:29PM +0800, Eugene Teo wrote:
Neil Horman wrote:
[...]
+ /* core limit size */
+ case 'c':
+ rc = snprintf(out_ptr, out_end - out_ptr,
+ %lu,
On Sat, Jul 28, 2007 at 03:52:02PM -0700, Jeremy Fitzhardinge wrote:
> Neil Horman wrote:
> > Jeremy asked that I make a patch next week to address split_argv's
> > requirement
> > that the argc parameter be non-NULL. I'll be fixing that next week, and
> > what I
> > can do is further enhance
Neil Horman wrote:
> Jeremy asked that I make a patch next week to address split_argv's requirement
> that the argc parameter be non-NULL. I'll be fixing that next week, and what
> I
> can do is further enhance it such that it ignores spaces in quoted strings,
> which should address the case
On Sat, Jul 28, 2007 at 06:17:25PM +0200, Martin Pitt wrote:
> Hi Neil,
>
> Neil Horman [2007-07-28 9:46 -0400]:
> > > I just want to mention a potential problem with this: If you first
> > > expand the macros (from pattern to corename) and then split
> > > corename into an argv, then this
Hi Neil,
Neil Horman [2007-07-28 9:46 -0400]:
> > I just want to mention a potential problem with this: If you first
> > expand the macros (from pattern to corename) and then split
> > corename into an argv, then this breaks macro expansions
> > containing spaces. This mostly affects the
On Sat, Jul 28, 2007 at 11:23:55AM +0200, Martin Pitt wrote:
> Hi Neil,
>
> thanks a lot for your work on this!
>
> Neil Horman [2007-07-27 16:08 -0400]:
> > Hey
> > Patch 2/3 of my core_pattern enhancements. This patch is a rewrite of
> > my previous post for this enhancement. It uses
Hi Neil,
thanks a lot for your work on this!
Neil Horman [2007-07-27 16:08 -0400]:
> Hey
> Patch 2/3 of my core_pattern enhancements. This patch is a rewrite of
> my previous post for this enhancement. It uses jeremy's split_argv/free_argv
> library functions to translate core_pattern
Hi Neil,
thanks a lot for your work on this!
Neil Horman [2007-07-27 16:08 -0400]:
Hey
Patch 2/3 of my core_pattern enhancements. This patch is a rewrite of
my previous post for this enhancement. It uses jeremy's split_argv/free_argv
library functions to translate core_pattern into
On Sat, Jul 28, 2007 at 11:23:55AM +0200, Martin Pitt wrote:
Hi Neil,
thanks a lot for your work on this!
Neil Horman [2007-07-27 16:08 -0400]:
Hey
Patch 2/3 of my core_pattern enhancements. This patch is a rewrite of
my previous post for this enhancement. It uses jeremy's
Hi Neil,
Neil Horman [2007-07-28 9:46 -0400]:
I just want to mention a potential problem with this: If you first
expand the macros (from pattern to corename) and then split
corename into an argv, then this breaks macro expansions
containing spaces. This mostly affects the executable
On Sat, Jul 28, 2007 at 06:17:25PM +0200, Martin Pitt wrote:
Hi Neil,
Neil Horman [2007-07-28 9:46 -0400]:
I just want to mention a potential problem with this: If you first
expand the macros (from pattern to corename) and then split
corename into an argv, then this breaks macro
Neil Horman wrote:
Jeremy asked that I make a patch next week to address split_argv's requirement
that the argc parameter be non-NULL. I'll be fixing that next week, and what
I
can do is further enhance it such that it ignores spaces in quoted strings,
which should address the case that
On Sat, Jul 28, 2007 at 03:52:02PM -0700, Jeremy Fitzhardinge wrote:
Neil Horman wrote:
Jeremy asked that I make a patch next week to address split_argv's
requirement
that the argc parameter be non-NULL. I'll be fixing that next week, and
what I
can do is further enhance it such that
On Fri, Jul 27, 2007 at 01:54:19PM -0700, Jeremy Fitzhardinge wrote:
> Neil Horman wrote:
> > + int helper_argc = 0;
> >
> > + helper_argv = argv_split(GFP_KERNEL, corename+1, _argc);
> >
>
> Hm, I suspect most users of argv_split don't really care about argc, so
> it would
Neil Horman wrote:
> + int helper_argc = 0;
>
> + helper_argv = argv_split(GFP_KERNEL, corename+1, _argc);
>
Hm, I suspect most users of argv_split don't really care about argc, so
it would useful to change argv_split to take NULL as the argc pointer,
rather than declare a
Hey
Patch 2/3 of my core_pattern enhancements. This patch is a rewrite of
my previous post for this enhancement. It uses jeremy's split_argv/free_argv
library functions to translate core_pattern into an argv array to be passed to
the user mode helper process. It also adds a translation
Hey
Patch 2/3 of my core_pattern enhancements. This patch is a rewrite of
my previous post for this enhancement. It uses jeremy's split_argv/free_argv
library functions to translate core_pattern into an argv array to be passed to
the user mode helper process. It also adds a translation
Neil Horman wrote:
+ int helper_argc = 0;
+ helper_argv = argv_split(GFP_KERNEL, corename+1, helper_argc);
Hm, I suspect most users of argv_split don't really care about argc, so
it would useful to change argv_split to take NULL as the argc pointer,
rather than declare a
On Fri, Jul 27, 2007 at 01:54:19PM -0700, Jeremy Fitzhardinge wrote:
Neil Horman wrote:
+ int helper_argc = 0;
+ helper_argv = argv_split(GFP_KERNEL, corename+1, helper_argc);
Hm, I suspect most users of argv_split don't really care about argc, so
it would useful to
30 matches
Mail list logo