Re: [PATCH 2/3] cxacru: Reduce initialisation delay

2007-09-23 Thread Simon Arlott
On 23/09/07 17:23, Duncan Sands wrote: > Hi Simon, > >> +usb_info(usbatm, "started firmware\n"); > ... >> +usb_info(usbatm, "loaded config data\n"); > > maybe these should be debug messages. When are they useful? They are probably only useful as debug messages - although it

Re: [PATCH 2/3] cxacru: Reduce initialisation delay

2007-09-23 Thread Duncan Sands
Hi Simon, > + usb_info(usbatm, "started firmware\n"); ... > + usb_info(usbatm, "loaded config data\n"); maybe these should be debug messages. When are they useful? Ciao, Duncan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[PATCH 2/3] cxacru: Reduce initialisation delay

2007-09-23 Thread Simon Arlott
Since card status updates appear to only occur every second, a delay of 1000ms on startup may not be sufficient - change to 1500ms. The long delay of 4000ms is likely to be related to the time required for the ADSL line to come up - the driver should not need to do this. Overall delay when

[PATCH 2/3] cxacru: Reduce initialisation delay

2007-09-23 Thread Simon Arlott
Since card status updates appear to only occur every second, a delay of 1000ms on startup may not be sufficient - change to 1500ms. The long delay of 4000ms is likely to be related to the time required for the ADSL line to come up - the driver should not need to do this. Overall delay when

Re: [PATCH 2/3] cxacru: Reduce initialisation delay

2007-09-23 Thread Duncan Sands
Hi Simon, + usb_info(usbatm, started firmware\n); ... + usb_info(usbatm, loaded config data\n); maybe these should be debug messages. When are they useful? Ciao, Duncan. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to

Re: [PATCH 2/3] cxacru: Reduce initialisation delay

2007-09-23 Thread Simon Arlott
On 23/09/07 17:23, Duncan Sands wrote: Hi Simon, +usb_info(usbatm, started firmware\n); ... +usb_info(usbatm, loaded config data\n); maybe these should be debug messages. When are they useful? They are probably only useful as debug messages - although it may be