Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-26 Thread Bjørn Mork
writes: > +static bool msi_en = 1; > +module_param(msi_en, bool, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(msi_en, "Enable MSI"); > + > +static bool adma_mode = 1; > +module_param(adma_mode, bool, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(adma_mode, "ADMA Mode"); Why would I want to disable these

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-26 Thread Rusty Russell
On Fri, 20 Jul 2012 18:09:26 +0800, wrote: > +static int msi_en = 1; > +module_param(msi_en, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(msi_en, "Enable MSI"); Should this be a bool, and a module_param(msi_en, bool, S_IRUGO | S_IWUSR);? > +static int adma_mode = 1; > +module_param(adma_mode,

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-26 Thread Rusty Russell
On Fri, 20 Jul 2012 18:09:26 +0800, wei_w...@realsil.com.cn wrote: +static int msi_en = 1; +module_param(msi_en, int, S_IRUGO | S_IWUSR); +MODULE_PARM_DESC(msi_en, Enable MSI); Should this be a bool, and a module_param(msi_en, bool, S_IRUGO | S_IWUSR);? +static int adma_mode = 1;

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-26 Thread Bjørn Mork
wei_w...@realsil.com.cn writes: +static bool msi_en = 1; +module_param(msi_en, bool, S_IRUGO | S_IWUSR); +MODULE_PARM_DESC(msi_en, Enable MSI); + +static bool adma_mode = 1; +module_param(adma_mode, bool, S_IRUGO | S_IWUSR); +MODULE_PARM_DESC(adma_mode, ADMA Mode); Why would I want to

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-23 Thread Borislav Petkov
On Mon, Jul 23, 2012 at 05:42:44PM +0800, wei_w...@realsil.com.cn wrote: > From: Wei WANG > > Realtek PCI-E card reader driver adapts requests from upper-level > sdmmc/memstick layer to the real physical card reader. > > Signed-off-by: Wei WANG Applying: drivers/misc: Add realtek pci card

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-23 Thread Borislav Petkov
On Mon, Jul 23, 2012 at 05:42:44PM +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Realtek PCI-E card reader driver adapts requests from upper-level sdmmc/memstick layer to the real physical card reader. Signed-off-by: Wei WANG wei_w...@realsil.com.cn

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-22 Thread wwang
Hi Rusty: Thank you. I will fix it and resend all of the three patches BR, wwang 于 2012年07月20日 13:58, Rusty Russell 写道: > On Thu, 19 Jul 2012 17:55:10 +0800, wrote: >> From: Wei WANG >> >> Realtek PCI-E card reader driver adapts requests from upper-level >> sdmmc/memstick layer to the real

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-22 Thread Rusty Russell
On Thu, 19 Jul 2012 17:55:10 +0800, wrote: > From: Wei WANG > > Realtek PCI-E card reader driver adapts requests from upper-level > sdmmc/memstick layer to the real physical card reader. > +static int msi_en = 1; > +module_param(msi_en, int, S_IRUGO | S_IWUSR); > +MODULE_PARM_DESC(msi_en,

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-22 Thread Rusty Russell
On Thu, 19 Jul 2012 17:55:10 +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Realtek PCI-E card reader driver adapts requests from upper-level sdmmc/memstick layer to the real physical card reader. +static int msi_en = 1; +module_param(msi_en, int, S_IRUGO |

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-22 Thread wwang
Hi Rusty: Thank you. I will fix it and resend all of the three patches BR, wwang 于 2012年07月20日 13:58, Rusty Russell 写道: On Thu, 19 Jul 2012 17:55:10 +0800, wei_w...@realsil.com.cn wrote: From: Wei WANG wei_w...@realsil.com.cn Realtek PCI-E card reader driver adapts requests from

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-19 Thread Oliver Neukum
On Thursday 19 July 2012 17:55:10 wei_w...@realsil.com.cn wrote: > +static int rtsx_pci_transfer_sglist_adma(struct rtsx_pdev *pdev, > + struct scatterlist *sg, int num_sg, int read, int timeout) > +{ > + struct completion trans_done; > + u8 dir; > + int buf_cnt, i; > +

Re: [PATCH 2/3] drivers/misc: Add realtek pci card reader driver

2012-07-19 Thread Oliver Neukum
On Thursday 19 July 2012 17:55:10 wei_w...@realsil.com.cn wrote: +static int rtsx_pci_transfer_sglist_adma(struct rtsx_pdev *pdev, + struct scatterlist *sg, int num_sg, int read, int timeout) +{ + struct completion trans_done; + u8 dir; + int buf_cnt, i; + int