Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Jaya Kumar
On Tue, Feb 26, 2008 at 9:45 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote: > > What about pushing the fb_defio fixes independently of any new > fb_defio users? If fb_defio was worth merging into Linus's tree, it > should be worth fixing there, whether new users are in shape already > or

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Markus Armbruster
"Jaya Kumar" <[EMAIL PROTECTED]> writes: > On Mon, Feb 25, 2008 at 8:03 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote: >> >> Subject: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb >> From: Jaya Kumar <[EMAIL PROTECTED]> >> Date: 2008-02-18 13:41:26 > > Hi Markus, > > Andrew

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Jaya Kumar
On Mon, Feb 25, 2008 at 8:03 AM, Markus Armbruster <[EMAIL PROTECTED]> wrote: > > Subject: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb > From: Jaya Kumar <[EMAIL PROTECTED]> > Date: 2008-02-18 13:41:26 Hi Markus, Andrew pointed out that there may be race conditions associated

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Jaya Kumar
On Mon, Feb 25, 2008 at 8:03 AM, Markus Armbruster [EMAIL PROTECTED] wrote: Subject: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb From: Jaya Kumar [EMAIL PROTECTED] Date: 2008-02-18 13:41:26 Hi Markus, Andrew pointed out that there may be race conditions associated with this

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Markus Armbruster
Jaya Kumar [EMAIL PROTECTED] writes: On Mon, Feb 25, 2008 at 8:03 AM, Markus Armbruster [EMAIL PROTECTED] wrote: Subject: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb From: Jaya Kumar [EMAIL PROTECTED] Date: 2008-02-18 13:41:26 Hi Markus, Andrew pointed out that there may

Re: [PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-26 Thread Jaya Kumar
On Tue, Feb 26, 2008 at 9:45 AM, Markus Armbruster [EMAIL PROTECTED] wrote: What about pushing the fb_defio fixes independently of any new fb_defio users? If fb_defio was worth merging into Linus's tree, it should be worth fixing there, whether new users are in shape already or not. I

[PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-25 Thread Markus Armbruster
Deferred I/O was utterly broken. Reading the mmap()ed framebuffer worked, but writing it made the VM endlessly invoke vm_ops.page_mkwrite(). That happened because we failed to set page->mapping and page->index. The fix is to set them, and clean up properly before the framebuffer gets released.

[PATCH 2/3] fbdev: Make deferred I/O work as advertized

2008-02-25 Thread Markus Armbruster
Deferred I/O was utterly broken. Reading the mmap()ed framebuffer worked, but writing it made the VM endlessly invoke vm_ops.page_mkwrite(). That happened because we failed to set page-mapping and page-index. The fix is to set them, and clean up properly before the framebuffer gets released.