Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-23 Thread Jonathan Cameron
On 20/08/15 01:23, Matt Porter wrote: > On Sat, Aug 08, 2015 at 12:39:40PM +0100, Jonathan Cameron wrote: >> On 06/08/15 18:38, Matt Porter wrote: >>> On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: On Mon, 3 Aug 2015, Matt Porter wrote: >>> >>> ... >>> > +static int

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-23 Thread Jonathan Cameron
On 20/08/15 01:23, Matt Porter wrote: On Sat, Aug 08, 2015 at 12:39:40PM +0100, Jonathan Cameron wrote: On 06/08/15 18:38, Matt Porter wrote: On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: On Mon, 3 Aug 2015, Matt Porter wrote: ... +static int max6675_read(struct

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-19 Thread Matt Porter
On Sat, Aug 08, 2015 at 12:39:40PM +0100, Jonathan Cameron wrote: > On 06/08/15 18:38, Matt Porter wrote: > > On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: > >> On Mon, 3 Aug 2015, Matt Porter wrote: > > > > ... > > > >>> +static int max6675_read(struct max6675_state *st, int

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-19 Thread Matt Porter
On Sat, Aug 08, 2015 at 12:39:40PM +0100, Jonathan Cameron wrote: On 06/08/15 18:38, Matt Porter wrote: On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: On Mon, 3 Aug 2015, Matt Porter wrote: ... +static int max6675_read(struct max6675_state *st, int *val) +{ +

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-08 Thread Jonathan Cameron
On 06/08/15 18:38, Matt Porter wrote: > On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: >> On Mon, 3 Aug 2015, Matt Porter wrote: > > ... > >>> +static int max6675_read(struct max6675_state *st, int *val) >>> +{ >>> + int ret; >>> + >>> + ret = spi_read(st->spi, val, 2); >>>

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-08 Thread Jonathan Cameron
On 06/08/15 18:38, Matt Porter wrote: On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: On Mon, 3 Aug 2015, Matt Porter wrote: ... +static int max6675_read(struct max6675_state *st, int *val) +{ + int ret; + + ret = spi_read(st-spi, val, 2); + if (ret 0) +

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-06 Thread Matt Porter
On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: > On Mon, 3 Aug 2015, Matt Porter wrote: ... > > +static int max6675_read(struct max6675_state *st, int *val) > > +{ > > + int ret; > > + > > + ret = spi_read(st->spi, val, 2); > > + if (ret < 0) > > + return ret; >

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-06 Thread Matt Porter
On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: On Mon, 3 Aug 2015, Matt Porter wrote: ... +static int max6675_read(struct max6675_state *st, int *val) +{ + int ret; + + ret = spi_read(st-spi, val, 2); + if (ret 0) + return ret; + + /*

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-04 Thread Matt Porter
On Tue, Aug 04, 2015 at 11:30:36AM +0200, Paul Bolle wrote: > On ma, 2015-08-03 at 16:56 -0400, Matt Porter wrote: > > --- /dev/null > > +++ b/drivers/iio/temperature/max6675.c > > +static const struct spi_device_id max6675_spi_ids[] = { > > + {"max6675", 0}, > > + {}, > > +}; > >

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-04 Thread Matt Porter
On Tue, Aug 04, 2015 at 10:50:32AM +0300, Daniel Baluta wrote: > On Mon, Aug 3, 2015 at 11:56 PM, Matt Porter wrote: > > Add a driver for the MAX6675 thermocouple converter. This > > device interfaces with K-type thermocouples and provides > > cold-junction compensated temperature readings via a

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-04 Thread Paul Bolle
On ma, 2015-08-03 at 16:56 -0400, Matt Porter wrote: > --- /dev/null > +++ b/drivers/iio/temperature/max6675.c > +static const struct spi_device_id max6675_spi_ids[] = { > + {"max6675", 0}, > + {}, > +}; > +MODULE_DEVICE_TABLE(spi, max6675_spi_ids); > +MODULE_ALIAS("spi:max6675"); For

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-04 Thread Daniel Baluta
On Mon, Aug 3, 2015 at 11:56 PM, Matt Porter wrote: > Add a driver for the MAX6675 thermocouple converter. This > device interfaces with K-type thermocouples and provides > cold-junction compensated temperature readings via a > SPI interface. ./scripts/checkpatch.pl --strict says: CHECK: braces

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-04 Thread Daniel Baluta
On Mon, Aug 3, 2015 at 11:56 PM, Matt Porter mpor...@konsulko.com wrote: Add a driver for the MAX6675 thermocouple converter. This device interfaces with K-type thermocouples and provides cold-junction compensated temperature readings via a SPI interface. ./scripts/checkpatch.pl --strict

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-04 Thread Paul Bolle
On ma, 2015-08-03 at 16:56 -0400, Matt Porter wrote: --- /dev/null +++ b/drivers/iio/temperature/max6675.c +static const struct spi_device_id max6675_spi_ids[] = { + {max6675, 0}, + {}, +}; +MODULE_DEVICE_TABLE(spi, max6675_spi_ids); +MODULE_ALIAS(spi:max6675); For the spi alias

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-04 Thread Matt Porter
On Tue, Aug 04, 2015 at 11:30:36AM +0200, Paul Bolle wrote: On ma, 2015-08-03 at 16:56 -0400, Matt Porter wrote: --- /dev/null +++ b/drivers/iio/temperature/max6675.c +static const struct spi_device_id max6675_spi_ids[] = { + {max6675, 0}, + {}, +}; +MODULE_DEVICE_TABLE(spi,

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-04 Thread Matt Porter
On Tue, Aug 04, 2015 at 10:50:32AM +0300, Daniel Baluta wrote: On Mon, Aug 3, 2015 at 11:56 PM, Matt Porter mpor...@konsulko.com wrote: Add a driver for the MAX6675 thermocouple converter. This device interfaces with K-type thermocouples and provides cold-junction compensated temperature

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Matt Porter
On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: > On Mon, 3 Aug 2015, Matt Porter wrote: > > > Add a driver for the MAX6675 thermocouple converter. This > > device interfaces with K-type thermocouples and provides > > cold-junction compensated temperature readings via a > > SPI

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Matt Porter
On Mon, Aug 03, 2015 at 03:39:00PM -0700, Matt Ranostay Matt Ranostay wrote: > On Mon, Aug 3, 2015 at 1:56 PM, Matt Porter wrote: ... > > +static int max6675_probe(struct spi_device *spi) > > +{ > > + struct iio_dev *indio_dev; > > + struct max6675_state *st; > > + int ret =

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Matt Ranostay
On Mon, Aug 3, 2015 at 1:56 PM, Matt Porter wrote: > Add a driver for the MAX6675 thermocouple converter. This > device interfaces with K-type thermocouples and provides > cold-junction compensated temperature readings via a > SPI interface. > > Signed-off-by: Matt Porter > --- >

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Peter Meerwald
On Mon, 3 Aug 2015, Matt Porter wrote: > Add a driver for the MAX6675 thermocouple converter. This > device interfaces with K-type thermocouples and provides > cold-junction compensated temperature readings via a > SPI interface. comments below > Signed-off-by: Matt Porter > --- >

[PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Matt Porter
Add a driver for the MAX6675 thermocouple converter. This device interfaces with K-type thermocouples and provides cold-junction compensated temperature readings via a SPI interface. Signed-off-by: Matt Porter --- drivers/iio/temperature/Kconfig | 11 +++ drivers/iio/temperature/Makefile |

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Matt Ranostay
On Mon, Aug 3, 2015 at 1:56 PM, Matt Porter mpor...@konsulko.com wrote: Add a driver for the MAX6675 thermocouple converter. This device interfaces with K-type thermocouples and provides cold-junction compensated temperature readings via a SPI interface. Signed-off-by: Matt Porter

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Matt Porter
On Mon, Aug 03, 2015 at 11:26:12PM +0200, Peter Meerwald wrote: On Mon, 3 Aug 2015, Matt Porter wrote: Add a driver for the MAX6675 thermocouple converter. This device interfaces with K-type thermocouples and provides cold-junction compensated temperature readings via a SPI interface.

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Matt Porter
On Mon, Aug 03, 2015 at 03:39:00PM -0700, Matt Ranostay Matt Ranostay wrote: On Mon, Aug 3, 2015 at 1:56 PM, Matt Porter mpor...@konsulko.com wrote: ... +static int max6675_probe(struct spi_device *spi) +{ + struct iio_dev *indio_dev; + struct max6675_state *st; +

Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Peter Meerwald
On Mon, 3 Aug 2015, Matt Porter wrote: Add a driver for the MAX6675 thermocouple converter. This device interfaces with K-type thermocouples and provides cold-junction compensated temperature readings via a SPI interface. comments below Signed-off-by: Matt Porter mpor...@konsulko.com ---

[PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver

2015-08-03 Thread Matt Porter
Add a driver for the MAX6675 thermocouple converter. This device interfaces with K-type thermocouples and provides cold-junction compensated temperature readings via a SPI interface. Signed-off-by: Matt Porter mpor...@konsulko.com --- drivers/iio/temperature/Kconfig | 11 +++