Re: [PATCH 2/3] jffs2: avoid soft-lockup in jffs2_reserve_space_gc()

2014-02-11 Thread Li Zefan
>> --- a/fs/jffs2/nodemgmt.c >> +++ b/fs/jffs2/nodemgmt.c >> @@ -216,15 +216,20 @@ int jffs2_reserve_space_gc(struct jffs2_sb_info *c, >> uint32_t minsize, >> >> jffs2_dbg(1, "%s(): Requested 0x%x bytes\n", __func__, minsize); >> >> -spin_lock(&c->erase_completion_lock); >> -while

Re: [PATCH 2/3] jffs2: avoid soft-lockup in jffs2_reserve_space_gc()

2014-02-11 Thread Brian Norris
Hi Andrew, On Tue, Feb 11, 2014 at 3:54 PM, Andrew Morton wrote: > On Sat, 8 Feb 2014 10:15:39 +0800 Li Zefan wrote: > I now have four jffs2 bugfixes but cannot unload them on anyone. > Waddup? Well, at best we have 3 "maintainers" involved in MTD (David, Artem, and me), but David is often quit

Re: [PATCH 2/3] jffs2: avoid soft-lockup in jffs2_reserve_space_gc()

2014-02-11 Thread Andrew Morton
On Sat, 8 Feb 2014 10:15:39 +0800 Li Zefan wrote: > We triggered soft-lockup under stress test on 2.6.34 kernel. > > BUG: soft lockup - CPU#1 stuck for 60009ms! [lockf2.test:14488] > ... > [] (jffs2_do_reserve_space+0x420/0x440 [jffs2]) > [] (jffs2_reserve_space_gc+0x34/0x78 [jffs2]) > [] (jffs2

[PATCH 2/3] jffs2: avoid soft-lockup in jffs2_reserve_space_gc()

2014-02-07 Thread Li Zefan
We triggered soft-lockup under stress test on 2.6.34 kernel. BUG: soft lockup - CPU#1 stuck for 60009ms! [lockf2.test:14488] ... [] (jffs2_do_reserve_space+0x420/0x440 [jffs2]) [] (jffs2_reserve_space_gc+0x34/0x78 [jffs2]) [] (jffs2_garbage_collect_dnode.isra.3+0x264/0x478 [jffs2]) [] (jffs2_garba