Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-19 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> gcc-6 complains about the indentation of the Arnd> lpfc_destroy_vport_work_array() call in lpfc_online(), which Arnd> clearly doesn't look right: Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-19 Thread Martin K. Petersen
> "Arnd" == Arnd Bergmann writes: Arnd> gcc-6 complains about the indentation of the Arnd> lpfc_destroy_vport_work_array() call in lpfc_online(), which Arnd> clearly doesn't look right: Applied to 4.6/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Sebastian Herbszt
Arnd Bergmann wrote: > gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array() > call in lpfc_online(), which clearly doesn't look right: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online': > drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Sebastian Herbszt
Arnd Bergmann wrote: > gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array() > call in lpfc_online(), which clearly doesn't look right: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online': > drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Ewan Milne
On Mon, 2016-03-14 at 16:26 +0100, Hannes Reinecke wrote: > On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: > >>> vports = lpfc_create_vport_work_array(phba); > >>> - if (vports != NULL) > >>> + if (vports != NULL) { > >>>

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Ewan Milne
On Mon, 2016-03-14 at 16:26 +0100, Hannes Reinecke wrote: > On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: > >>> vports = lpfc_create_vport_work_array(phba); > >>> - if (vports != NULL) > >>> + if (vports != NULL) { > >>>

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: >>> vports = lpfc_create_vport_work_array(phba); >>> - if (vports != NULL) >>> + if (vports != NULL) { >>> for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++)

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 04:25 PM, Arnd Bergmann wrote: > On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: >>> vports = lpfc_create_vport_work_array(phba); >>> - if (vports != NULL) >>> + if (vports != NULL) { >>> for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++)

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Arnd Bergmann
On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: > > vports = lpfc_create_vport_work_array(phba); > > - if (vports != NULL) > > + if (vports != NULL) { > > for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) { > > struct Scsi_Host

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Arnd Bergmann
On Monday 14 March 2016 16:19:58 Hannes Reinecke wrote: > > vports = lpfc_create_vport_work_array(phba); > > - if (vports != NULL) > > + if (vports != NULL) { > > for (i = 0; i <= phba->max_vports && vports[i] != NULL; i++) { > > struct Scsi_Host

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 03:29 PM, Arnd Bergmann wrote: > gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array() > call in lpfc_online(), which clearly doesn't look right: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online': > drivers/scsi/lpfc/lpfc_init.c:2880:3: warning:

Re: [PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Hannes Reinecke
On 03/14/2016 03:29 PM, Arnd Bergmann wrote: > gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array() > call in lpfc_online(), which clearly doesn't look right: > > drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online': > drivers/scsi/lpfc/lpfc_init.c:2880:3: warning:

[PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Arnd Bergmann
gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array() call in lpfc_online(), which clearly doesn't look right: drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online': drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if it were guarded by...

[PATCH 2/3] lpfc: fix misleading indentation

2016-03-14 Thread Arnd Bergmann
gcc-6 complains about the indentation of the lpfc_destroy_vport_work_array() call in lpfc_online(), which clearly doesn't look right: drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_online': drivers/scsi/lpfc/lpfc_init.c:2880:3: warning: statement is indented as if it were guarded by...