Re: [PATCH 2/3] media/videobuf1|2: Mark follow_pfn usage as unsafe

2021-03-17 Thread Daniel Vetter
On Wed, Mar 17, 2021 at 8:22 AM Christoph Hellwig wrote: > On Tue, Mar 16, 2021 at 04:52:44PM +0100, Daniel Vetter wrote: > > My understanding is mostly, but with some objections. And I kinda > > don't want to let this die in a bikeshed and then not getting rid of > > follow_pfn as a result.

Re: [PATCH 2/3] media/videobuf1|2: Mark follow_pfn usage as unsafe

2021-03-17 Thread Christoph Hellwig
On Tue, Mar 16, 2021 at 04:52:44PM +0100, Daniel Vetter wrote: > My understanding is mostly, but with some objections. And I kinda > don't want to let this die in a bikeshed and then not getting rid of > follow_pfn as a result. There's enough people who acked this, and the > full removal got some

Re: [PATCH 2/3] media/videobuf1|2: Mark follow_pfn usage as unsafe

2021-03-16 Thread Daniel Vetter
On Tue, Mar 16, 2021 at 4:46 PM Christoph Hellwig wrote: > > On Tue, Mar 16, 2021 at 04:33:02PM +0100, Daniel Vetter wrote: > > The media model assumes that buffers are all preallocated, so that > > when a media pipeline is running we never miss a deadline because the > > buffers aren't allocated

Re: [PATCH 2/3] media/videobuf1|2: Mark follow_pfn usage as unsafe

2021-03-16 Thread Christoph Hellwig
On Tue, Mar 16, 2021 at 04:33:02PM +0100, Daniel Vetter wrote: > The media model assumes that buffers are all preallocated, so that > when a media pipeline is running we never miss a deadline because the > buffers aren't allocated or available. > > This means we cannot fix the v4l follow_pfn

[PATCH 2/3] media/videobuf1|2: Mark follow_pfn usage as unsafe

2021-03-16 Thread Daniel Vetter
The media model assumes that buffers are all preallocated, so that when a media pipeline is running we never miss a deadline because the buffers aren't allocated or available. This means we cannot fix the v4l follow_pfn usage through mmu_notifier, without breaking how this all works. The only