Re: [PATCH 2/3] media: videodev2.h: clarify v4l2_pix_format_mplane.sizeimage docs when to set to zero

2021-01-25 Thread Helen Koike
On 1/25/21 6:31 AM, Hans Verkuil wrote: > On 14/01/2021 19:01, Helen Koike wrote: >> sizeimage field should be set to zero for unused planes, even when >> v4l2_pix_format_mplane.num_planes is smaller then the index of planes. > > then -> than Ack. > >> >> Signed-off-by: Helen Koike >> >>

Re: [PATCH 2/3] media: videodev2.h: clarify v4l2_pix_format_mplane.sizeimage docs when to set to zero

2021-01-25 Thread Hans Verkuil
On 14/01/2021 19:01, Helen Koike wrote: > sizeimage field should be set to zero for unused planes, even when > v4l2_pix_format_mplane.num_planes is smaller then the index of planes. then -> than > > Signed-off-by: Helen Koike > > --- > > I caught this with v4l2-compliance, which throws an

Re: [PATCH 2/3] media: videodev2.h: clarify v4l2_pix_format_mplane.sizeimage docs when to set to zero

2021-01-16 Thread Sakari Ailus
Hi Helen, Thanks for the patch. On Thu, Jan 14, 2021 at 03:01:48PM -0300, Helen Koike wrote: > sizeimage field should be set to zero for unused planes, even when > v4l2_pix_format_mplane.num_planes is smaller then the index of planes. > > Signed-off-by: Helen Koike > > --- > > I caught this

Re: [PATCH 2/3] media: videodev2.h: clarify v4l2_pix_format_mplane.sizeimage docs when to set to zero

2021-01-15 Thread Jacopo Mondi
Hi Helen On Thu, Jan 14, 2021 at 03:01:48PM -0300, Helen Koike wrote: > sizeimage field should be set to zero for unused planes, even when > v4l2_pix_format_mplane.num_planes is smaller then the index of planes. > > Signed-off-by: Helen Koike > > --- > > I caught this with v4l2-compliance, which

[PATCH 2/3] media: videodev2.h: clarify v4l2_pix_format_mplane.sizeimage docs when to set to zero

2021-01-14 Thread Helen Koike
sizeimage field should be set to zero for unused planes, even when v4l2_pix_format_mplane.num_planes is smaller then the index of planes. Signed-off-by: Helen Koike --- I caught this with v4l2-compliance, which throws an error if we dirty planes, even if invalid, so I would like to make it