Re: [PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-29 Thread Bjorn Andersson
On Thu, May 29, 2014 at 2:41 PM, Srinivas Kandagatla wrote: >> Although we will not have more than one rpm in a system and therefore not >> instatiate this driver multiple times I do not want to run it off the >> global >> state. >> > I agree. > > Why not make a separate data structure for the

Re: [PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-29 Thread Srinivas Kandagatla
On 29/05/14 20:45, Bjorn Andersson wrote: On Thu, May 29, 2014 at 9:19 AM, Srinivas Kandagatla wrote: +++ b/drivers/mfd/qcom_rpm.c the line spacing looks bit odd. I'll fix +}; + +#define RPM_STATUS_REG(rpm, i) ((rpm)->status_regs + (i) * 4) +#define RPM_CTRL_REG(rpm, i)

Re: [PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-29 Thread Bjorn Andersson
On Thu, May 29, 2014 at 9:19 AM, Srinivas Kandagatla wrote: >> +++ b/drivers/mfd/qcom_rpm.c [...] >> +struct qcom_rpm { >> + struct device *dev; >> + struct completion ack; >> + struct mutex lock; >> + >> + void __iomem *status_regs; >> + void __iomem *ctrl_regs;

Re: [PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-29 Thread Srinivas Kandagatla
Hi Bjorn, On 27/05/14 18:28, Bjorn Andersson wrote: Driver for the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 and 8064 based devices. The driver exposes resources that child drivers can operate on; to implementing regulator, clock and bus frequency drivers. Signed-off-by: Bjorn

Re: [PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-29 Thread Srinivas Kandagatla
Hi Bjorn, On 27/05/14 18:28, Bjorn Andersson wrote: Driver for the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 and 8064 based devices. The driver exposes resources that child drivers can operate on; to implementing regulator, clock and bus frequency drivers. Signed-off-by: Bjorn

Re: [PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-29 Thread Bjorn Andersson
On Thu, May 29, 2014 at 9:19 AM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: +++ b/drivers/mfd/qcom_rpm.c [...] +struct qcom_rpm { + struct device *dev; + struct completion ack; + struct mutex lock; + + void __iomem *status_regs; + void __iomem

Re: [PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-29 Thread Srinivas Kandagatla
On 29/05/14 20:45, Bjorn Andersson wrote: On Thu, May 29, 2014 at 9:19 AM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: +++ b/drivers/mfd/qcom_rpm.c the line spacing looks bit odd. I'll fix +}; + +#define RPM_STATUS_REG(rpm, i) ((rpm)-status_regs + (i) * 4) +#define

Re: [PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-29 Thread Bjorn Andersson
On Thu, May 29, 2014 at 2:41 PM, Srinivas Kandagatla srinivas.kandaga...@linaro.org wrote: Although we will not have more than one rpm in a system and therefore not instatiate this driver multiple times I do not want to run it off the global state. I agree. Why not make a separate data

[PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-27 Thread Bjorn Andersson
Driver for the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 and 8064 based devices. The driver exposes resources that child drivers can operate on; to implementing regulator, clock and bus frequency drivers. Signed-off-by: Bjorn Andersson --- drivers/mfd/Kconfig | 15 ++

[PATCH 2/3] mfd: qcom-rpm: Driver for the Qualcomm RPM

2014-05-27 Thread Bjorn Andersson
Driver for the Resource Power Manager (RPM) found in Qualcomm 8660, 8960 and 8064 based devices. The driver exposes resources that child drivers can operate on; to implementing regulator, clock and bus frequency drivers. Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com ---