Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Mike Rapoport
On Wed, Mar 20, 2019 at 06:13:18PM +0800, Baoquan He wrote: > Hi Mike, > > On 03/20/19 at 09:56am, Mike Rapoport wrote: > > @@ -697,16 +697,17 @@ int __meminit sparse_add_one_section(int nid, > unsigned long start_pfn, > > > ret = sparse_index_init(section_nr, nid); > > > if (ret < 0 && ret

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Matthew Wilcox
On Wed, Mar 20, 2019 at 06:13:18PM +0800, Baoquan He wrote: > + if (!memmap) { > + ret = -ENOMEM; > + goto out2; Documentation/process/coding-style: Choose label names which say what the goto does or why the goto exists. An example of a good name could be ``out_free_b

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Baoquan He
Hi Mike, On 03/20/19 at 09:56am, Mike Rapoport wrote: > @@ -697,16 +697,17 @@ int __meminit sparse_add_one_section(int nid, unsigned > long start_pfn, > > ret = sparse_index_init(section_nr, nid); > > if (ret < 0 && ret != -EEXIST) > > return ret; > > - ret = 0; > > - me

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Baoquan He
On 03/20/19 at 09:56am, Mike Rapoport wrote: > > diff --git a/mm/sparse.c b/mm/sparse.c > > index 0a0f82c5d969..054b99f74181 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -697,16 +697,17 @@ int __meminit sparse_add_one_section(int nid, > > unsigned long start_pfn, > > ret = sparse_

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Mike Rapoport
On Wed, Mar 20, 2019 at 03:35:39PM +0800, Baoquan He wrote: > Reorder the allocation of usemap and memmap since usemap allocation > is much smaller and simpler. Otherwise hard work is done to make > memmap ready, then have to rollback just because of usemap allocation > failure. > > Signed-off-by:

[PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Baoquan He
Reorder the allocation of usemap and memmap since usemap allocation is much smaller and simpler. Otherwise hard work is done to make memmap ready, then have to rollback just because of usemap allocation failure. Signed-off-by: Baoquan He --- mm/sparse.c | 13 +++-- 1 file changed, 7 inse