Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2015-01-23 Thread Stefan Strogin
Hello Gioh, On 31/12/14 04:14, Gioh Kim wrote: > > Is it ok if the information is too big? > I'm not sure but I remember that seq_printf has 4K limitation. Thanks for reviewing, excuse me for a long delay. If I understand correctly it is OK, since it's written in comments for seq_has_overflowed(

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2015-01-22 Thread Joonsoo Kim
On Thu, Jan 22, 2015 at 06:35:53PM +0300, Stefan Strogin wrote: > Hello Joonsoo, > > On 30/12/14 07:38, Joonsoo Kim wrote: > > On Fri, Dec 26, 2014 at 05:39:03PM +0300, Stefan I. Strogin wrote: > >> /proc/cmainfo contains a list of currently allocated CMA buffers for every > >> CMA area when CONFI

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2015-01-22 Thread Stefan Strogin
Hello Joonsoo, On 30/12/14 07:38, Joonsoo Kim wrote: > On Fri, Dec 26, 2014 at 05:39:03PM +0300, Stefan I. Strogin wrote: >> /proc/cmainfo contains a list of currently allocated CMA buffers for every >> CMA area when CONFIG_CMA_DEBUG is enabled. > Hello, > > I think that providing these informatio

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2015-01-21 Thread Stefan Strogin
Hello Laura, On 30/12/14 00:11, Laura Abbott wrote: > > This seems better suited to debugfs over procfs, especially since the > option can be turned off. It would be helpful to break it > down by cma region as well to make it easier on systems with a lot > of regions. > > Thanks, > Laura > I thou

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2014-12-30 Thread Gioh Kim
2014-12-29 오후 11:09에 Stefan Strogin 이(가) 쓴 글: Thanks for review Michał, On 12/26/2014 07:02 PM, Michal Nazarewicz wrote: On Fri, Dec 26 2014, "Stefan I. Strogin" wrote: /proc/cmainfo contains a list of currently allocated CMA buffers for every CMA area when CONFIG_CMA_DEBUG is enabled. For

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2014-12-29 Thread Joonsoo Kim
On Fri, Dec 26, 2014 at 05:39:03PM +0300, Stefan I. Strogin wrote: > /proc/cmainfo contains a list of currently allocated CMA buffers for every > CMA area when CONFIG_CMA_DEBUG is enabled. Hello, I think that providing these information looks useful, but, we need better implementation. As Laura s

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2014-12-29 Thread Laura Abbott
On 12/26/2014 6:39 AM, Stefan I. Strogin wrote: /proc/cmainfo contains a list of currently allocated CMA buffers for every CMA area when CONFIG_CMA_DEBUG is enabled. Format is: - ( kB), allocated by \ (), latency us Signed-off-by: Stefan I. Strogin --- ... +static int

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2014-12-29 Thread Michal Nazarewicz
>> On Fri, Dec 26 2014, "Stefan I. Strogin" >> wrote: >>> + if (ret) { >>> + pr_warn("%s(): cma_buffer_list_add() returned %d\n", >>> + __func__, ret); >>> + cma_release(cma, page, count); >>> + page = NULL;

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2014-12-29 Thread Stefan Strogin
Thanks for review Michał, On 12/26/2014 07:02 PM, Michal Nazarewicz wrote: On Fri, Dec 26 2014, "Stefan I. Strogin" wrote: /proc/cmainfo contains a list of currently allocated CMA buffers for every CMA area when CONFIG_CMA_DEBUG is enabled. Format is: - ( kB), allocated by \

Re: [PATCH 2/3] mm: cma: introduce /proc/cmainfo

2014-12-26 Thread Michal Nazarewicz
On Fri, Dec 26 2014, "Stefan I. Strogin" wrote: > /proc/cmainfo contains a list of currently allocated CMA buffers for every > CMA area when CONFIG_CMA_DEBUG is enabled. > > Format is: > > - ( kB), allocated by \ > (), latency us > > > Signed-off-by: Stefan I. Strogin > --- >

[PATCH 2/3] mm: cma: introduce /proc/cmainfo

2014-12-26 Thread Stefan I. Strogin
/proc/cmainfo contains a list of currently allocated CMA buffers for every CMA area when CONFIG_CMA_DEBUG is enabled. Format is: - ( kB), allocated by \ (), latency us Signed-off-by: Stefan I. Strogin --- mm/cma.c | 202 +