Re: [PATCH 2/3] mm: throttle on IO only when there are too many dirty and writeback pages

2016-03-19 Thread Tetsuo Handa
Today I was testing -- diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 6915c950e6e8..aa52e23ac280 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -887,7 +887,7 @@ void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, { struct wb_writeback_work

Re: [PATCH 2/3] mm: throttle on IO only when there are too many dirty and writeback pages

2016-03-19 Thread Tetsuo Handa
Today I was testing -- diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 6915c950e6e8..aa52e23ac280 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -887,7 +887,7 @@ void wb_start_writeback(struct bdi_writeback *wb, long nr_pages, { struct wb_writeback_work

Re: [PATCH 2/3] mm: throttle on IO only when there are too many dirty and writeback pages

2016-03-19 Thread Michal Hocko
On Thu 17-03-16 20:35:23, Tetsuo Handa wrote: [...] > But what I felt strange is what should_reclaim_retry() is doing. > > Michal Hocko wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index f77e283fb8c6..b2de8c8761ad 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@

Re: [PATCH 2/3] mm: throttle on IO only when there are too many dirty and writeback pages

2016-03-19 Thread Michal Hocko
On Thu 17-03-16 20:35:23, Tetsuo Handa wrote: [...] > But what I felt strange is what should_reclaim_retry() is doing. > > Michal Hocko wrote: > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > > index f77e283fb8c6..b2de8c8761ad 100644 > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@

[PATCH 2/3] mm: throttle on IO only when there are too many dirty and writeback pages

2015-12-15 Thread Michal Hocko
From: Michal Hocko wait_iff_congested has been used to throttle allocator before it retried another round of direct reclaim to allow the writeback to make some progress and prevent reclaim from looping over dirty/writeback pages without making any progress. We used to do congestion_wait before

[PATCH 2/3] mm: throttle on IO only when there are too many dirty and writeback pages

2015-12-15 Thread Michal Hocko
From: Michal Hocko wait_iff_congested has been used to throttle allocator before it retried another round of direct reclaim to allow the writeback to make some progress and prevent reclaim from looping over dirty/writeback pages without making any progress. We used to do