Re: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc

2014-07-01 Thread Zhou Wang
On 2014年06月30日 17:45, Ivan Khoronzhuk wrote: On 06/30/2014 11:03 AM, Zhou Wang wrote: Signed-off-by: Zhou Wang --- drivers/mtd/nand/Kconfig |5 + drivers/mtd/nand/Makefile|1 + drivers/mtd/nand/hisi_nand.c | 847 ++ 3 files changed,

Re: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc

2014-07-01 Thread Zhou Wang
On 2014年06月30日 17:00, Arnd Bergmann wrote: Overall a very nice driver. I didn't find any real bugs, but a few things that could be changed for readability and micro-optimizations: On Monday 30 June 2014 16:03:28 Zhou Wang wrote: +#define hinfc_read(_host, _reg)readl(_host->iobase + (_r

Re: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc

2014-06-30 Thread Ivan Khoronzhuk
On 06/30/2014 11:03 AM, Zhou Wang wrote: Signed-off-by: Zhou Wang --- drivers/mtd/nand/Kconfig |5 + drivers/mtd/nand/Makefile|1 + drivers/mtd/nand/hisi_nand.c | 847 ++ 3 files changed, 853 insertions(+) create mode 100644 driver

Re: [PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc

2014-06-30 Thread Arnd Bergmann
Overall a very nice driver. I didn't find any real bugs, but a few things that could be changed for readability and micro-optimizations: On Monday 30 June 2014 16:03:28 Zhou Wang wrote: > +#define hinfc_read(_host, _reg) readl(_host->iobase + (_reg)) > +#define hinfc_write(_host, _value, _re

[PATCH 2/3] mtd: hisilicon: add a new nand controller driver for hisilicon hip04 Soc

2014-06-30 Thread Zhou Wang
Signed-off-by: Zhou Wang --- drivers/mtd/nand/Kconfig |5 + drivers/mtd/nand/Makefile|1 + drivers/mtd/nand/hisi_nand.c | 847 ++ 3 files changed, 853 insertions(+) create mode 100644 drivers/mtd/nand/hisi_nand.c diff --git a/drivers/mtd/