Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter

2020-11-02 Thread Tsuchiya Yuto
On Fri, 2020-10-30 at 13:02 +0200, Andy Shevchenko wrote: > On Fri, Oct 30, 2020 at 04:58:33PM +0900, Tsuchiya Yuto wrote: > > On Wed, 2020-10-28 at 15:04 -0700, Brian Norris wrote: > > ... > > > On the other hand, I agree that I don't want to break the existing users. > > As you mentioned in

Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter

2020-10-30 Thread Andy Shevchenko
On Fri, Oct 30, 2020 at 04:58:33PM +0900, Tsuchiya Yuto wrote: > On Wed, 2020-10-28 at 15:04 -0700, Brian Norris wrote: ... > On the other hand, I agree that I don't want to break the existing users. > As you mentioned in the reply to the first patch, I can set the default > value of this

Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter

2020-10-30 Thread Tsuchiya Yuto
On Thu, 2020-10-29 at 13:04 -0400, Willem de Bruijn wrote: > On Wed, Oct 28, 2020 at 9:13 PM Brian Norris wrote: > > > > On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto wrote: > > > > > > To make the ps_mode (power_save) control easier, this commit adds a new > > > module parameter allow_ps_mode

Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter

2020-10-30 Thread Tsuchiya Yuto
On Wed, 2020-10-28 at 15:04 -0700, Brian Norris wrote: > On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto wrote: > > > > To make the ps_mode (power_save) control easier, this commit adds a new > > module parameter allow_ps_mode and set it false (disallowed) by default. > > This sounds like a bad

Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter

2020-10-29 Thread Willem de Bruijn
On Wed, Oct 28, 2020 at 9:13 PM Brian Norris wrote: > > On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto wrote: > > > > To make the ps_mode (power_save) control easier, this commit adds a new > > module parameter allow_ps_mode and set it false (disallowed) by default. This sounds like some form of

Re: [PATCH 2/3] mwifiex: add allow_ps_mode module parameter

2020-10-28 Thread Brian Norris
On Wed, Oct 28, 2020 at 2:56 PM Tsuchiya Yuto wrote: > > To make the ps_mode (power_save) control easier, this commit adds a new > module parameter allow_ps_mode and set it false (disallowed) by default. This sounds like a bad idea, as it breaks all the existing users who expect this feature to

[PATCH 2/3] mwifiex: add allow_ps_mode module parameter

2020-10-28 Thread Tsuchiya Yuto
To make the ps_mode (power_save) control easier, this commit adds a new module parameter allow_ps_mode and set it false (disallowed) by default. When this parameter is set to false, changing the power_save mode will be disallowed like the following: $ sudo iw dev mlan0 set power_save on