Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Benjamin Herrenschmidt
On Mon, 2005-03-14 at 16:19 +0100, Segher Boessenkool wrote: > > On possibiliy would be to have the kernel replace spaces with > > underscores for the sake of matching. That would make life easier for > > everybody. > > Yes, that'll probably work just fine. Or use 0xb1, showing that this > is "p

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Segher Boessenkool
I choose the spec. If an implementation is not conformant to the spec, it doesn't "work". Not to say that Linux doesn't have to work around bugs in actual implementations, of course. And there's a lot of those. Too bad ;-) Yah, well.. ok, let's say we have a spec... and an implementation that

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Benjamin Herrenschmidt wrote: >>>Well, we have an unmaintained spec on one side that can't even be >>>ordered from IEEE anymore and actual imlementations that work today, >>>what do you chose ? ;) >> >>I choose the spec. If an implementation is not co

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Benjamin Herrenschmidt
> > Well, we have an unmaintained spec on one side that can't even be > > ordered from IEEE anymore and actual imlementations that work today, > > what do you chose ? ;) > > I choose the spec. If an implementation is not conformant to the spec, > it doesn't "work". > > Not to say that Linux doe

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Segher Boessenkool
Is whitespace (in any form) allowed in the compatible value? No. Only printable characters are allowed, that is, byte values 0x21..0x7e and 0xa1..0xfe; each text string is terminated by a 0x00; there can be several text strings concatenated in one "compatible" property. Yes, whitespace is used at

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Olaf Hering
On Tue, Mar 15, Benjamin Herrenschmidt wrote: > what do you chose ? ;) I'm sure Rusty will prefer the non-whitespace version for depmod and module.alias - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Benjamin Herrenschmidt
On Sun, 2005-03-13 at 16:17 +0100, Segher Boessenkool wrote: > Sorry to follow up this late... > > >>> Is whitespace (in any form) allowed in the compatible value? > > No. Only printable characters are allowed, that is, byte values > 0x21..0x7e and 0xa1..0xfe; each text string is terminated by a

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-14 Thread Segher Boessenkool
Sorry to follow up this late... Is whitespace (in any form) allowed in the compatible value? No. Only printable characters are allowed, that is, byte values 0x21..0x7e and 0xa1..0xfe; each text string is terminated by a 0x00; there can be several text strings concatenated in one "compatible" prope

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-04 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Olaf Hering wrote: > On Thu, Mar 03, Jeff Mahoney wrote: > > >>-BEGIN PGP SIGNED MESSAGE- >>Hash: SHA1 >> >>Olaf Hering wrote: >> >>> On Thu, Mar 03, Jeff Mahoney wrote: >>> >>> >>> Is whitespace (in any form) allowed in the compatible v

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-04 Thread Olaf Hering
On Thu, Mar 03, Jeff Mahoney wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > Olaf Hering wrote: > > On Thu, Mar 03, Jeff Mahoney wrote: > > > > > >>Is whitespace (in any form) allowed in the compatible value? > > > > > > Yes, whitespace is used at least in the toplevel compatib

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-03 Thread Benjamin Herrenschmidt
> Reviewing the 'compatible' values in my device-tree, I definately agree. > I can hack the pmac_zilog driver to test this out further - I've just > been using my airport card. > > Are there any other "invalid" characters for the compatible property? > CRLF would work, but these values (as a grou

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-03 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Olaf Hering wrote: > On Thu, Mar 03, Jeff Mahoney wrote: > > >>Is whitespace (in any form) allowed in the compatible value? > > > Yes, whitespace is used at least in the toplevel compatible file, like > 'Power Macintosh' in some Pismo models. >

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-03 Thread Olaf Hering
On Thu, Mar 03, Jeff Mahoney wrote: > Is whitespace (in any form) allowed in the compatible value? Yes, whitespace is used at least in the toplevel compatible file, like 'Power Macintosh' in some Pismo models. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-03 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Benjamin Herrenschmidt wrote: > On Tue, 2005-03-01 at 16:18 -0500, Jeffrey Mahoney wrote: > >>This patch adds sysfs nodes that the hotplug userspace can use to load the >>appropriate modules. >> >>In order for hotplug to work with macio devices, patch

Re: [PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-02 Thread Benjamin Herrenschmidt
On Tue, 2005-03-01 at 16:18 -0500, Jeffrey Mahoney wrote: > This patch adds sysfs nodes that the hotplug userspace can use to load the > appropriate modules. > > In order for hotplug to work with macio devices, patches to module-init-tools > and hotplug must be applied. Those patches are available

[PATCH 2/3] openfirmware: adds sysfs nodes for openfirmware devices

2005-03-01 Thread Jeffrey Mahoney
This patch adds sysfs nodes that the hotplug userspace can use to load the appropriate modules. In order for hotplug to work with macio devices, patches to module-init-tools and hotplug must be applied. Those patches are available at: ftp://ftp.suse.com/pub/people/jeffm/linux/macio-hotplug/ Sign