Re: [PATCH 2/3] orangefs: strncpy -> strlcpy

2016-04-08 Thread martin
On Fri, 8 Apr 2016, Andy Shevchenko wrote: > On Fri, Apr 8, 2016 at 6:34 PM, wrote: > >> On Thu, Apr 7, 2016 at 2:39 PM, Andy Shevchenko > >> wrote: > >> > On Mon, Apr 4, 2016 at 11:26 PM, Martin Brandenburg > >> > wrote: > >> >> From: Martin Brandenburg > >> >> > >> >> Almost everywhere we

Re: [PATCH 2/3] orangefs: strncpy -> strlcpy

2016-04-08 Thread Andy Shevchenko
On Fri, Apr 8, 2016 at 6:34 PM, wrote: >> On Thu, Apr 7, 2016 at 2:39 PM, Andy Shevchenko >> wrote: >> > On Mon, Apr 4, 2016 at 11:26 PM, Martin Brandenburg >> > wrote: >> >> From: Martin Brandenburg >> >> >> >> Almost everywhere we use strncpy we should use strlcpy. This affects >> >> path n

Re: [PATCH 2/3] orangefs: strncpy -> strlcpy

2016-04-08 Thread martin
> On Thu, Apr 7, 2016 at 2:39 PM, Andy Shevchenko > wrote: > > On Mon, Apr 4, 2016 at 11:26 PM, Martin Brandenburg > > wrote: > >> From: Martin Brandenburg > >> > >> Almost everywhere we use strncpy we should use strlcpy. This affects > >> path names (d_name mostly), symlink targets, and server

Re: [PATCH 2/3] orangefs: strncpy -> strlcpy

2016-04-07 Thread Mike Marshall
It looks like strscpy went in last October... there are no users of it yet. I was just about to send in a pull request that includes Martin's strncpy->strlcpy patch when I saw Andy's comment. Linus said when he pulled strscpy: > So I'm pulling the strscpy() support because it *is* a better interf

Re: [PATCH 2/3] orangefs: strncpy -> strlcpy

2016-04-07 Thread Andy Shevchenko
On Mon, Apr 4, 2016 at 11:26 PM, Martin Brandenburg wrote: > From: Martin Brandenburg > > Almost everywhere we use strncpy we should use strlcpy. This affects > path names (d_name mostly), symlink targets, and server names. > > Leave debugfs code as is for now, though it could use a review as wel

[PATCH 2/3] orangefs: strncpy -> strlcpy

2016-04-04 Thread Martin Brandenburg
From: Martin Brandenburg Almost everywhere we use strncpy we should use strlcpy. This affects path names (d_name mostly), symlink targets, and server names. Leave debugfs code as is for now, though it could use a review as well. Signed-off-by: Martin Brandenburg --- fs/orangefs/dcache.c