Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

Hello, Sorry for late reply, I missed this in the mailbox.. On Wed, Nov 18, 2015 at 03:26:54PM +0800, Wangnan (F) wrote: > On 2015/11/18 13:41, Namhyung Kim wrote: > >On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: > >> > >>On 2015/11/17 23:05, Jiri Olsa wrote: > >>>From: Jiri Olsa

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

Hello, Sorry for late reply, I missed this in the mailbox.. On Wed, Nov 18, 2015 at 03:26:54PM +0800, Wangnan (F) wrote: > On 2015/11/18 13:41, Namhyung Kim wrote: > >On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: > >> > >>On 2015/11/17 23:05, Jiri Olsa wrote: > >>>From: Jiri Olsa

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On November 18, 2015 5:25:25 PM GMT+09:00, Jiri Olsa wrote: >On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote: > >SNIP > >> > I'm not sure whether we can regard this behavior changing as a >bugfix? I >> > think >> > there may be some reason the original code explicitly avoid >creating

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote: SNIP > > I think callchain value being 0 is an error or marker for the end of > callchain. So it'd be better avoiding 0 entry. > > But unfortunately, we have many 0 entries (and broken callchain after > them) with fp recording on

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote: SNIP > > I'm not sure whether we can regard this behavior changing as a bugfix? I > > think > > there may be some reason the original code explicitly avoid creating an '0' > > entry. > > I think callchain value being 0 is an error or

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 08:54:31AM +0100, Jiri Olsa wrote: > On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: > > SNIP > > > 3.38% a.outa.out [.] funcc > > | > > ---funcc > > | > > |--2.70%-- funcb >

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On 2015/11/18 15:54, Jiri Olsa wrote: On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: SNIP 3.38% a.outa.out [.] funcc | ---funcc | |--2.70%-- funcb | funca

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On 2015/11/18 15:54, Jiri Olsa wrote: On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: SNIP 3.38% a.outa.out [.] funcc | ---funcc | |--2.70%-- funcb | funca

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote: SNIP > > I think callchain value being 0 is an error or marker for the end of > callchain. So it'd be better avoiding 0 entry. > > But unfortunately, we have many 0 entries (and broken callchain after > them) with fp recording on

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 08:54:31AM +0100, Jiri Olsa wrote: > On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: > > SNIP > > > 3.38% a.outa.out [.] funcc > > | > > ---funcc > > | > > |--2.70%-- funcb >

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote: SNIP > > I'm not sure whether we can regard this behavior changing as a bugfix? I > > think > > there may be some reason the original code explicitly avoid creating an '0' > > entry. > > I think callchain value being 0 is an error or

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On November 18, 2015 5:25:25 PM GMT+09:00, Jiri Olsa wrote: >On Wed, Nov 18, 2015 at 02:41:14PM +0900, Namhyung Kim wrote: > >SNIP > >> > I'm not sure whether we can regard this behavior changing as a >bugfix? I >> > think >> > there may be some reason the original code

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: SNIP > 3.38% a.outa.out [.] funcc > | > ---funcc > | > |--2.70%-- funcb > | funca > | main >

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On 2015/11/18 13:41, Namhyung Kim wrote: On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: On 2015/11/17 23:05, Jiri Olsa wrote: From: Jiri Olsa As reported by Milian, currently for DWARF unwind (both libdw and libunwind) we display callchain in callee order only. Adding the

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: > > > On 2015/11/17 23:05, Jiri Olsa wrote: > >From: Jiri Olsa > > > >As reported by Milian, currently for DWARF unwind (both libdw > >and libunwind) we display callchain in callee order only. > > > >Adding the support to follow

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On 2015/11/17 23:05, Jiri Olsa wrote: From: Jiri Olsa As reported by Milian, currently for DWARF unwind (both libdw and libunwind) we display callchain in callee order only. Adding the support to follow callchain order setup to libunwind DWARF unwinder, so we could get following output for

[PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

From: Jiri Olsa As reported by Milian, currently for DWARF unwind (both libdw and libunwind) we display callchain in callee order only. Adding the support to follow callchain order setup to libunwind DWARF unwinder, so we could get following output for report: $ perf record --call-graph

[PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

From: Jiri Olsa As reported by Milian, currently for DWARF unwind (both libdw and libunwind) we display callchain in callee order only. Adding the support to follow callchain order setup to libunwind DWARF unwinder, so we could get following output for report: $ perf record

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: > > > On 2015/11/17 23:05, Jiri Olsa wrote: > >From: Jiri Olsa > > > >As reported by Milian, currently for DWARF unwind (both libdw > >and libunwind) we display callchain in callee order only. > > > >Adding the

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On 2015/11/17 23:05, Jiri Olsa wrote: From: Jiri Olsa As reported by Milian, currently for DWARF unwind (both libdw and libunwind) we display callchain in callee order only. Adding the support to follow callchain order setup to libunwind DWARF unwinder, so we could get

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On 2015/11/18 13:41, Namhyung Kim wrote: On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: On 2015/11/17 23:05, Jiri Olsa wrote: From: Jiri Olsa As reported by Milian, currently for DWARF unwind (both libdw and libunwind) we display callchain in callee order

Re: [PATCH 2/3] perf tools: Add callchain order support for libunwind DWARF unwinder

On Wed, Nov 18, 2015 at 12:13:08PM +0800, Wangnan (F) wrote: SNIP > 3.38% a.outa.out [.] funcc > | > ---funcc > | > |--2.70%-- funcb > | funca > | main >