Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-05-07 Thread Ingo Molnar
* Jiri Olsa wrote: > On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: > > 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > > > Keeping the data file description open for the whole life > > > of the dso object. > > > > I suspect there might be an issue for reporting very large data file >

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-05-07 Thread Ingo Molnar
* Jiri Olsa jo...@redhat.com wrote: On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: 2014-04-17 (목), 19:39 +0200, Jiri Olsa: Keeping the data file description open for the whole life of the dso object. I suspect there might be an issue for reporting very large data

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread Namhyung Kim
Hi David, On Mon, 28 Apr 2014 08:57:49 -0600, David Ahern wrote: > On 4/28/14, 7:16 AM, Namhyung Kim wrote: >> 2014-04-28 (월), 12:01 +0200, Jiri Olsa: >>> On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > Keeping the data file

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread David Ahern
On 4/28/14, 7:16 AM, Namhyung Kim wrote: 2014-04-28 (월), 12:01 +0200, Jiri Olsa: On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: 2014-04-17 (목), 19:39 +0200, Jiri Olsa: Keeping the data file description open for the whole life of the dso object. I suspect there might be an

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread Jiri Olsa
On Mon, Apr 28, 2014 at 10:16:34PM +0900, Namhyung Kim wrote: > 2014-04-28 (월), 12:01 +0200, Jiri Olsa: > > On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: > > > 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > > > > Keeping the data file description open for the whole life > > > > of the

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread Namhyung Kim
2014-04-28 (월), 12:01 +0200, Jiri Olsa: > On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: > > 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > > > Keeping the data file description open for the whole life > > > of the dso object. > > > > I suspect there might be an issue for reporting very

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread Jiri Olsa
On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: > 2014-04-17 (목), 19:39 +0200, Jiri Olsa: > > Keeping the data file description open for the whole life > > of the dso object. > > I suspect there might be an issue for reporting very large data file > with this approach - like open

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread Jiri Olsa
On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: 2014-04-17 (목), 19:39 +0200, Jiri Olsa: Keeping the data file description open for the whole life of the dso object. I suspect there might be an issue for reporting very large data file with this approach - like open file

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread Namhyung Kim
2014-04-28 (월), 12:01 +0200, Jiri Olsa: On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: 2014-04-17 (목), 19:39 +0200, Jiri Olsa: Keeping the data file description open for the whole life of the dso object. I suspect there might be an issue for reporting very large data

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread Jiri Olsa
On Mon, Apr 28, 2014 at 10:16:34PM +0900, Namhyung Kim wrote: 2014-04-28 (월), 12:01 +0200, Jiri Olsa: On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: 2014-04-17 (목), 19:39 +0200, Jiri Olsa: Keeping the data file description open for the whole life of the dso object.

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread David Ahern
On 4/28/14, 7:16 AM, Namhyung Kim wrote: 2014-04-28 (월), 12:01 +0200, Jiri Olsa: On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: 2014-04-17 (목), 19:39 +0200, Jiri Olsa: Keeping the data file description open for the whole life of the dso object. I suspect there might be an

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-28 Thread Namhyung Kim
Hi David, On Mon, 28 Apr 2014 08:57:49 -0600, David Ahern wrote: On 4/28/14, 7:16 AM, Namhyung Kim wrote: 2014-04-28 (월), 12:01 +0200, Jiri Olsa: On Sun, Apr 27, 2014 at 11:36:35PM +0900, Namhyung Kim wrote: 2014-04-17 (목), 19:39 +0200, Jiri Olsa: Keeping the data file description open for

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-27 Thread Namhyung Kim
2014-04-17 (목), 19:39 +0200, Jiri Olsa: > Keeping the data file description open for the whole life > of the dso object. I suspect there might be an issue for reporting very large data file with this approach - like open file limit? [SNIP] > @@ -168,8 +174,8 @@ int dso__data_fd(struct dso *dso,

Re: [PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-27 Thread Namhyung Kim
2014-04-17 (목), 19:39 +0200, Jiri Olsa: Keeping the data file description open for the whole life of the dso object. I suspect there might be an issue for reporting very large data file with this approach - like open file limit? [SNIP] @@ -168,8 +174,8 @@ int dso__data_fd(struct dso *dso,

[PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-17 Thread Jiri Olsa
Keeping the data file description open for the whole life of the dso object. The report shows just little speedup in dso__data_fd function for report command processing dwarf unwind stacks. Output from report over 1.5 GB data with DWARF unwind stacks: (TODO fix perf diff) current code:

[PATCH 2/3] perf tools: Cache dso data file descriptor

2014-04-17 Thread Jiri Olsa
Keeping the data file description open for the whole life of the dso object. The report shows just little speedup in dso__data_fd function for report command processing dwarf unwind stacks. Output from report over 1.5 GB data with DWARF unwind stacks: (TODO fix perf diff) current code: