Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-13 Thread Linus Walleij
On Mon, Jul 9, 2018 at 5:37 PM Stephen Boyd wrote: > Quoting Linus Walleij (2018-07-09 06:54:01) > > On Mon, Jul 2, 2018 at 7:56 PM Stephen Boyd wrote: > > > > > I could do with some more clarity from Linus in the "Drivers needing > > > both pin control and GPIOs" section of > > > Documentation/d

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-09 Thread Stephen Boyd
Quoting Linus Walleij (2018-07-09 06:54:01) > On Mon, Jul 2, 2018 at 7:56 PM Stephen Boyd wrote: > > > I could do with some more clarity from Linus in the "Drivers needing > > both pin control and GPIOs" section of > > Documentation/driver-api/pinctl.rst but I read that section as stating > > tha

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-09 Thread Linus Walleij
On Mon, Jul 2, 2018 at 7:56 PM Stephen Boyd wrote: > I could do with some more clarity from Linus in the "Drivers needing > both pin control and GPIOs" section of > Documentation/driver-api/pinctl.rst but I read that section as stating > that the GPIO driver needs to mux the pin as a GPIO by requ

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-06 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-07-02 12:09:22) > On Thu 28 Jun 10:14 PDT 2018, Stephen Boyd wrote: > > > Quoting Linus Walleij (2018-06-28 07:25:46) > > > On Fri, Jun 22, 2018 at 8:29 PM Bjorn Andersson > > > wrote: > > > > On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: > > > > > On Mon 18 J

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-02 Thread Bjorn Andersson
On Thu 28 Jun 10:14 PDT 2018, Stephen Boyd wrote: > Quoting Linus Walleij (2018-06-28 07:25:46) > > On Fri, Jun 22, 2018 at 8:29 PM Bjorn Andersson > > wrote: > > > On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: > > > > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > > > > > > > We

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-07-02 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-28 11:45:30) > Hi, > > On Thu, Jun 28, 2018 at 10:14 AM, Stephen Boyd wrote: > > Quoting Linus Walleij (2018-06-28 07:25:46) > >> On Fri, Jun 22, 2018 at 8:29 PM Bjorn Andersson > >> wrote: > >> > On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: > >> > > On Mon

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-28 Thread Doug Anderson
Hi, On Thu, Jun 28, 2018 at 10:14 AM, Stephen Boyd wrote: > Quoting Linus Walleij (2018-06-28 07:25:46) >> On Fri, Jun 22, 2018 at 8:29 PM Bjorn Andersson >> wrote: >> > On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: >> > > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: >> > > >> > > >

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-28 Thread Stephen Boyd
Quoting Linus Walleij (2018-06-28 07:25:46) > On Fri, Jun 22, 2018 at 8:29 PM Bjorn Andersson > wrote: > > On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: > > > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > > > > > We rely on devices to use pinmuxing configurations in DT to select t

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-28 Thread Linus Walleij
On Fri, Jun 22, 2018 at 8:29 PM Bjorn Andersson wrote: > On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: > > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > > > We rely on devices to use pinmuxing configurations in DT to select the > > > GPIO function (function 0) if they're going to

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-22 Thread Bjorn Andersson
On Fri 22 Jun 10:58 PDT 2018, Bjorn Andersson wrote: > On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > > > We rely on devices to use pinmuxing configurations in DT to select the > > GPIO function (function 0) if they're going to use the gpio in GPIO > > mode. Let's simplify things for driver

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-22 Thread Bjorn Andersson
On Mon 18 Jun 13:52 PDT 2018, Stephen Boyd wrote: > We rely on devices to use pinmuxing configurations in DT to select the > GPIO function (function 0) if they're going to use the gpio in GPIO > mode. Let's simplify things for driver authors by implementing > gpio_request_enable() for this pinctrl

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-19 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-19 14:38:57) > On Tue, Jun 19, 2018 at 2:18 PM, Stephen Boyd wrote: > > Quoting Doug Anderson (2018-06-18 16:54:49) > >> > >> Is there a reason why you'd want to return 0 instead of some sort of > >> error code? Wouldn't you want to know that this pin can't be a GPI

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-19 Thread Doug Anderson
Hi, On Tue, Jun 19, 2018 at 2:18 PM, Stephen Boyd wrote: > Quoting Doug Anderson (2018-06-18 16:54:49) >> Hi, >> >> On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: >> > We rely on devices to use pinmuxing configurations in DT to select the >> > GPIO function (function 0) if they're going to

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-19 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-18 16:54:49) > Hi, > > On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > > We rely on devices to use pinmuxing configurations in DT to select the > > GPIO function (function 0) if they're going to use the gpio in GPIO > > mode. Let's simplify things for driver

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-18 Thread Doug Anderson
Hi, On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > We rely on devices to use pinmuxing configurations in DT to select the > GPIO function (function 0) if they're going to use the gpio in GPIO > mode. Let's simplify things for driver authors by implementing > gpio_request_enable() for this

[PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-18 Thread Stephen Boyd
We rely on devices to use pinmuxing configurations in DT to select the GPIO function (function 0) if they're going to use the gpio in GPIO mode. Let's simplify things for driver authors by implementing gpio_request_enable() for this pinctrl driver to mux out the GPIO function when the gpio is use f