Re: [PATCH 2/3] pinctrl: remove superfluous optimization in pinctrl_select_state_locked

2013-04-03 Thread Linus Walleij
On Thu, Mar 28, 2013 at 12:55 PM, Richard Genoud wrote: > As Stephen Warren suggested, checking first if the setting->node entry > is the first in the list or not is superfluous, as it is checked again > in the list_for_each_entry bellow. > So, remove it, the code will be simpler and lighter ! >

Re: [PATCH 2/3] pinctrl: remove superfluous optimization in pinctrl_select_state_locked

2013-03-28 Thread Stephen Warren
On 03/28/2013 05:55 AM, Richard Genoud wrote: > As Stephen Warren suggested, checking first if the setting->node entry > is the first in the list or not is superfluous, as it is checked again > in the list_for_each_entry bellow. > So, remove it, the code will be simpler and lighter ! Reviewed-by:

[PATCH 2/3] pinctrl: remove superfluous optimization in pinctrl_select_state_locked

2013-03-28 Thread Richard Genoud
As Stephen Warren suggested, checking first if the setting->node entry is the first in the list or not is superfluous, as it is checked again in the list_for_each_entry bellow. So, remove it, the code will be simpler and lighter ! Signed-off-by: Richard Genoud --- If can also be squashed whit com