Re: [PATCH 2/3] power: increment wakeup_count when save_wakeup_count failed.

2015-05-17 Thread Rafael J. Wysocki
On Friday, May 15, 2015 06:08:32 PM Jin Qian wrote: > Some wakeup event happens every frequently between reading > wakeup_count and writing back wakeup_count. > They changed wakeup event count so writes fail and usespace doesn't > continue to suspend. However, such > occurrences are not counted in

Re: [PATCH 2/3] power: increment wakeup_count when save_wakeup_count failed.

2015-05-15 Thread Jin Qian
Some wakeup event happens every frequently between reading wakeup_count and writing back wakeup_count. They changed wakeup event count so writes fail and usespace doesn't continue to suspend. However, such occurrences are not counted in ws->wakeup_count. I spent quite sometime finding out the probl

Re: [PATCH 2/3] power: increment wakeup_count when save_wakeup_count failed.

2015-05-15 Thread Rafael J. Wysocki
On Wednesday, April 22, 2015 05:50:11 PM Jin Qian wrote: > user-space aborts suspend attempt if writing wakeup_count failed. > Count the write failure towards wakeup_count. A use case, please? > Signed-off-by: Jin Qian > --- > drivers/base/power/wakeup.c | 17 + > 1 file changed

Re: [PATCH 2/3] power: increment wakeup_count when save_wakeup_count failed.

2015-04-27 Thread Jin Qian
Sorry about duplicate email. Sent in text mode so that it's delivered to mailing list. write fails when there's any new wakeup event after previous read. https://www.kernel.org/doc/Documentation/ABI/testing/sysfs-power What: /sys/power/wakeup_count Date: July 2010 Contact: Rafael J. Wysocki Des

Re: [PATCH 2/3] power: increment wakeup_count when save_wakeup_count failed.

2015-04-25 Thread Pavel Machek
On Wed 2015-04-22 17:50:11, Jin Qian wrote: > user-space aborts suspend attempt if writing wakeup_count failed. > Count the write failure towards wakeup_count. Why should writing wakeup_count fail? Can you make sure it does not happen, instead?

[PATCH 2/3] power: increment wakeup_count when save_wakeup_count failed.

2015-04-22 Thread Jin Qian
user-space aborts suspend attempt if writing wakeup_count failed. Count the write failure towards wakeup_count. Signed-off-by: Jin Qian --- drivers/base/power/wakeup.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c