Re: [PATCH 2/3] printk/console: Clean up logic around fallback console

2017-06-15 Thread Sergey Senozhatsky
On (06/15/17 17:31), Petr Mladek wrote: [..] > > diff --git a/include/linux/console.h b/include/linux/console.h > > index b8920a031a3e..a2525e0d7605 100644 > > --- a/include/linux/console.h > > +++ b/include/linux/console.h > > @@ -127,7 +127,7 @@ static inline int con_debug_leave(void) > > */ >

Re: [PATCH 2/3] printk/console: Clean up logic around fallback console

2017-06-15 Thread Petr Mladek
On Wed 2017-06-14 17:38:03, Sergey Senozhatsky wrote: > Thanks for taking a look at this. > > On (06/13/17 14:54), Petr Mladek wrote: > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index 8ebc480fdbc6..6e651f68bffd 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/print

Re: [PATCH 2/3] printk/console: Clean up logic around fallback console

2017-06-14 Thread Sergey Senozhatsky
Thanks for taking a look at this. On (06/13/17 14:54), Petr Mladek wrote: > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > index 8ebc480fdbc6..6e651f68bffd 100644 > --- a/kernel/printk/printk.c > +++ b/kernel/printk/printk.c > @@ -2413,51 +2413,45 @@ void register_console(struct co

[PATCH 2/3] printk/console: Clean up logic around fallback console

2017-06-13 Thread Petr Mladek
register_console() has a fallback code that enables the first usable console when a preferred one is not set. Though the logic is really tangled by the variable "has_preferred" The only purpose of the variable is to decide whether we use the fallback code or not. It is set when the console setup s