Re: [PATCH 2/3] rtc: Add support for the MediaTek MT2712 RTC

On 17/07/2019 16:54:54+0800, Ran Bi wrote: > > > + > > > +/* we map HW YEAR 0 to 1968 not 1970 because 2000 is the leap year */ > > > +#define RTC_MIN_YEAR 1968 > > > +#define RTC_BASE_YEAR1900 > > > +#define RTC_MIN_YEAR_OFFSET (RTC_MIN_YEAR - RTC_BASE_YEAR) > > > >

Re: [PATCH 2/3] rtc: Add support for the MediaTek MT2712 RTC

Hi Belloni, On Sat, 2019-07-13 at 23:12 +0200, Alexandre Belloni wrote: > > +#define RTC_BBPU 0x > > +#define RTC_BBPU_CLRPKY(1U << 4) > > Please use BIT(). Also, I don't feel that the RTC prefix is adding any > value. MT2712 would be a better choice here. > Will

Re: [PATCH 2/3] rtc: Add support for the MediaTek MT2712 RTC

Hi, On 02/07/2019 11:21:19+0800, Ran Bi wrote: > diff --git a/drivers/rtc/rtc-mt2712.c b/drivers/rtc/rtc-mt2712.c > new file mode 100644 > index ..f98f0ab114c5 > --- /dev/null > +++ b/drivers/rtc/rtc-mt2712.c > @@ -0,0 +1,495 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + *

[PATCH 2/3] rtc: Add support for the MediaTek MT2712 RTC

This add support for the MediaTek MT2712 RTC. It was SoC based RTC, but had different architecture compared with MT7622 RTC. Signed-off-by: Ran Bi --- drivers/rtc/Kconfig | 10 + drivers/rtc/Makefile | 1 + drivers/rtc/rtc-mt2712.c | 495 +++ 3