Re: [PATCH 2/3] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-08 Thread Valentin Schneider
On 08/08/2019 10:24, Qais Yousef wrote: >> @@ -8834,6 +8834,10 @@ static inline enum alb_status >> active_load_balance(struct lb_env *env) >> >> raw_spin_lock_irqsave(&busiest->lock, flags); >> >> +/* Make sure we're not about to stop a task from a higher sched class */ >> +if (bu

Re: [PATCH 2/3] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-08 Thread Qais Yousef
On 08/07/19 18:40, Valentin Schneider wrote: > The CFS load balancer can cause the cpu_stopper to run a function to > try and steal a rq's currently running task. However, it so happens > that while only CFS tasks will ever be migrated by that function, we > can end up preempting higher sched class

[PATCH 2/3] sched/fair: Prevent active LB from preempting higher sched classes

2019-08-07 Thread Valentin Schneider
The CFS load balancer can cause the cpu_stopper to run a function to try and steal a rq's currently running task. However, it so happens that while only CFS tasks will ever be migrated by that function, we can end up preempting higher sched class tasks, since it is executed by the cpu_stopper. I d