Re: [PATCH 2/3] smack: call WARN_ONCE() instead of calling audit_log_start()

2013-12-08 Thread Richard Guy Briggs
On Fri, Dec 06, 2013 at 10:40:56AM -0800, Casey Schaufler wrote: > On 12/4/2013 6:45 PM, Richard Guy Briggs wrote: > > Remove the call to audit_log() (which call audit_log_start()) and deal with > > the errors in the caller, logging only once if the condition is met. > > Calling > > audit_log_sta

Re: [PATCH 2/3] smack: call WARN_ONCE() instead of calling audit_log_start()

2013-12-06 Thread Casey Schaufler
On 12/4/2013 6:45 PM, Richard Guy Briggs wrote: > Remove the call to audit_log() (which call audit_log_start()) and deal with > the errors in the caller, logging only once if the condition is met. Calling > audit_log_start() in this location makes buffer allocation and locking more > complicated i

[PATCH 2/3] smack: call WARN_ONCE() instead of calling audit_log_start()

2013-12-04 Thread Richard Guy Briggs
Remove the call to audit_log() (which call audit_log_start()) and deal with the errors in the caller, logging only once if the condition is met. Calling audit_log_start() in this location makes buffer allocation and locking more complicated in the calling tree (audit_filter_user()). Signed-off-by