Re: [PATCH 2/3] soc: amlogic: Add support for Secure power domains controller

2019-09-26 Thread Kevin Hilman
Jianxin Pan writes: > Hi Kevin, > > Thanks for your review. Please see my comments below. > > > On 2019/9/26 6:41, Kevin Hilman wrote: >> Hi Jianxin, >> >> Jianxin Pan writes: >> >>> Add support for the Amlogic Secure Power controller. In A1/C1 series, power >>> control registers are in secure

Re: [PATCH 2/3] soc: amlogic: Add support for Secure power domains controller

2019-09-26 Thread Jianxin Pan
Hi Kevin, Thanks for your review. Please see my comments below. On 2019/9/26 6:41, Kevin Hilman wrote: > Hi Jianxin, > > Jianxin Pan writes: > >> Add support for the Amlogic Secure Power controller. In A1/C1 series, power >> control registers are in secure domain, and should be accessed by sm

Re: [PATCH 2/3] soc: amlogic: Add support for Secure power domains controller

2019-09-25 Thread Kevin Hilman
Hi Jianxin, Jianxin Pan writes: > Add support for the Amlogic Secure Power controller. In A1/C1 series, power > control registers are in secure domain, and should be accessed by smc. > > Signed-off-by: Jianxin Pan > Signed-off-by: Zhiqiang Liang Thanks for the new power domain driver. > ---

Re: [PATCH 2/3] soc: amlogic: Add support for Secure power domains controller

2019-09-20 Thread Jianxin Pan
Hi Martin, On 2019/9/20 4:03, Martin Blumenstingl wrote: > Hi Jianxin, > > I added three comments below from a quick glance at this driver (I > didn't have time for a complete review) > > On Thu, Sep 19, 2019 at 2:11 PM Jianxin Pan wrote: > [...] >> + pm_genpd_init(&dom->base, NUL

Re: [PATCH 2/3] soc: amlogic: Add support for Secure power domains controller

2019-09-19 Thread Martin Blumenstingl
Hi Jianxin, I added three comments below from a quick glance at this driver (I didn't have time for a complete review) On Thu, Sep 19, 2019 at 2:11 PM Jianxin Pan wrote: [...] > + pm_genpd_init(&dom->base, NULL, > + (match->domains[i].get_power ? > +

[PATCH 2/3] soc: amlogic: Add support for Secure power domains controller

2019-09-19 Thread Jianxin Pan
Add support for the Amlogic Secure Power controller. In A1/C1 series, power control registers are in secure domain, and should be accessed by smc. Signed-off-by: Jianxin Pan Signed-off-by: Zhiqiang Liang --- drivers/soc/amlogic/Kconfig | 13 +++ drivers/soc/amlogic/Makefile