Re: [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

2019-04-24 Thread Kamalesh Babulal
On Wed, Apr 24, 2019 at 10:55:49AM +0200, Petr Mladek wrote: > WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. > The only current user klp_check_stack() writes its own warning when > -ENOSYS is returned. > > Signed-off-by: Petr Mladek Reviewed-by: Kamalesh Babulal --

Re: [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

2019-04-24 Thread Miroslav Benes
On Wed, 24 Apr 2019, Petr Mladek wrote: > WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. > The only current user klp_check_stack() writes its own warning when > -ENOSYS is returned. > > Signed-off-by: Petr Mladek Acked-by: Miroslav Benes Miroslav

Re: [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

2019-04-24 Thread Josh Poimboeuf
On Wed, Apr 24, 2019 at 10:55:49AM +0200, Petr Mladek wrote: > WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. > The only current user klp_check_stack() writes its own warning when > -ENOSYS is returned. > > Signed-off-by: Petr Mladek > --- > kernel/stacktrace.c | 1 -

Re: [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

2019-04-24 Thread Josh Poimboeuf
Adding Thomas because this might slightly conflict with some of the stacktrace.c improvements he's working on. On Wed, Apr 24, 2019 at 10:55:49AM +0200, Petr Mladek wrote: > WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. > The only current user klp_check_stack() writes

Re: [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

2019-04-24 Thread Petr Mladek
On Wed 2019-04-24 10:55:49, Petr Mladek wrote: > WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. > The only current user klp_check_stack() writes its own warning when > -ENOSYS is returned. Suggested-by: Josh Poimboeuf > Signed-off-by: Petr Mladek Best Regards, Petr

[PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable()

2019-04-24 Thread Petr Mladek
WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. The only current user klp_check_stack() writes its own warning when -ENOSYS is returned. Signed-off-by: Petr Mladek --- kernel/stacktrace.c | 1 - 1 file changed, 1 deletion(-) diff --git a/kernel/stacktrace.c b/kernel/s