Re: [PATCH 2/3] staging/slicoss: disable pci device at remove

2012-07-10 Thread devendra.aaru
On Wed, Jul 11, 2012 at 12:13 AM, Greg Kroah-Hartman wrote: >> I haven't see this? Why don't you want to disable a device at remove >> time? Because we put the disable in the generic pci layer? > > For some reason, I thought we didn't do this because of other > "interfaces" on the same card migh

Re: [PATCH 2/3] staging/slicoss: disable pci device at remove

2012-07-10 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2012 at 01:09:23PM -0700, Eric W. Biederman wrote: > Greg Kroah-Hartman writes: > > > On Mon, Jul 09, 2012 at 11:04:19PM +0530, Devendra Naga wrote: > >> at probe we enabled the device, and we should disable it at remove. > >> > >> Signed-off-by: Devendra Naga > >> --- > >> dri

Re: [PATCH 2/3] staging/slicoss: disable pci device at remove

2012-07-09 Thread Eric W. Biederman
Greg Kroah-Hartman writes: > On Mon, Jul 09, 2012 at 11:04:19PM +0530, Devendra Naga wrote: >> at probe we enabled the device, and we should disable it at remove. >> >> Signed-off-by: Devendra Naga >> --- >> drivers/staging/slicoss/slicoss.c |1 + >> 1 file changed, 1 insertion(+) >> >> d

Re: [PATCH 2/3] staging/slicoss: disable pci device at remove

2012-07-09 Thread Greg Kroah-Hartman
On Mon, Jul 09, 2012 at 11:04:19PM +0530, Devendra Naga wrote: > at probe we enabled the device, and we should disable it at remove. > > Signed-off-by: Devendra Naga > --- > drivers/staging/slicoss/slicoss.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/slicoss/sli

[PATCH 2/3] staging/slicoss: disable pci device at remove

2012-07-09 Thread Devendra Naga
at probe we enabled the device, and we should disable it at remove. Signed-off-by: Devendra Naga --- drivers/staging/slicoss/slicoss.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c index a511a2b..5bd3825 100644 --- a