Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-23 Thread Alex Courbot
On Wednesday 23 January 2013 17:45:39 Alex Courbot wrote: > > I'm confused. Why would you want to call into pwm_bl directly? If we're > > going to split this up into separate platform devices, why not look up a > > given backlight device and use the backlight API on that? The pieces of > > the puzz

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-23 Thread Alex Courbot
On Wednesday 23 January 2013 18:15:30 Leela Krishna Amudala wrote: > > + pwm_backlight_set_subdriver_data(dev, data); > > Here you are passing ventana_bl_data pointer as input and in the > pwm_backlight_get_subdriver_data() function you are assigning the > received driver data to backlight_d

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-23 Thread Leela Krishna Amudala
Hello Alex, On Sat, Jan 19, 2013 at 4:00 PM, Alexandre Courbot wrote: > > Add a PWM-backlight subdriver for Tegra boards, with support for > Ventana. > > Signed-off-by: Alexandre Courbot > --- > arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- > arch/arm/configs/tegra_defconfig | 1 +

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-23 Thread Alex Courbot
> I'm confused. Why would you want to call into pwm_bl directly? If we're > going to split this up into separate platform devices, why not look up a > given backlight device and use the backlight API on that? The pieces of > the puzzle are all there: you can use of_find_backlight_by_node() to > obt

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-22 Thread Stephen Warren
On 01/21/2013 08:24 PM, Alex Courbot wrote: > On Tuesday 22 January 2013 01:46:33 Stephen Warren wrote: >>> arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- >>> arch/arm/configs/tegra_defconfig | 1 + >>> drivers/video/backlight/Kconfig| 7 ++ >>> drivers/video/backlight/pwm_bl

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Thierry Reding
On Tue, Jan 22, 2013 at 12:24:34PM +0900, Alex Courbot wrote: > On Tuesday 22 January 2013 01:46:33 Stephen Warren wrote: > > > arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- > > > arch/arm/configs/tegra_defconfig | 1 + > > > drivers/video/backlight/Kconfig| 7 ++ > > > driv

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Alex Courbot
On Tuesday 22 January 2013 01:46:33 Stephen Warren wrote: > > arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- > > arch/arm/configs/tegra_defconfig | 1 + > > drivers/video/backlight/Kconfig| 7 ++ > > drivers/video/backlight/pwm_bl.c | 3 + > > drivers/video/backlight/

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Stephen Warren
On 01/19/2013 03:30 AM, Alexandre Courbot wrote: > Add a PWM-backlight subdriver for Tegra boards, with support for > Ventana. > > Signed-off-by: Alexandre Courbot > --- > arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- > arch/arm/configs/tegra_defconfig | 1 + > drivers/video/backlig

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Mark Zhang
On 01/21/2013 04:52 PM, Marc Dietrich wrote: > Hi, > >>> diff --git a/drivers/video/backlight/pwm_bl_tegra.c >>> b/drivers/video/backlight/pwm_bl_tegra.c new file mode 100644 >>> index 000..8f2195b >>> --- /dev/null >>> +++ b/drivers/video/backlight/pwm_bl_tegra.c >> >> So according to the fil

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Marc Dietrich
Hi, > > diff --git a/drivers/video/backlight/pwm_bl_tegra.c > > b/drivers/video/backlight/pwm_bl_tegra.c new file mode 100644 > > index 000..8f2195b > > --- /dev/null > > +++ b/drivers/video/backlight/pwm_bl_tegra.c > > So according to the filename, I think we can put all tegra boards codes >

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Mark Zhang
On 01/21/2013 04:24 PM, Alex Courbot wrote: > On Monday 21 January 2013 15:35:58 Mark Zhang wrote: >>> + backlight { >>> + compatible = "pwm-backlight-ventana"; >>> + brightness-levels = <0 16 32 48 64 80 96 112 128 144 160 176 >>> 192 > 208 >>> 224 240 255>; + d

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Alex Courbot
On Monday 21 January 2013 15:35:58 Mark Zhang wrote: > > + backlight { > > + compatible = "pwm-backlight-ventana"; > > + brightness-levels = <0 16 32 48 64 80 96 112 128 144 160 176 > > 192 208 > > 224 240 255>; + default-brightness-level = <12>; > > + > > +

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-20 Thread Mark Zhang
On 01/19/2013 06:30 PM, Alexandre Courbot wrote: > Add a PWM-backlight subdriver for Tegra boards, with support for > Ventana. > > Signed-off-by: Alexandre Courbot > --- [...] > > + backlight { > + compatible = "pwm-backlight-ventana"; > + brightness-levels = <0 16 3

[PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-19 Thread Alexandre Courbot
Add a PWM-backlight subdriver for Tegra boards, with support for Ventana. Signed-off-by: Alexandre Courbot --- arch/arm/boot/dts/tegra20-ventana.dts | 18 +++- arch/arm/configs/tegra_defconfig | 1 + drivers/video/backlight/Kconfig| 7 ++ drivers/video/backlight/pwm_bl.c