Re: [PATCH 2/3] uprobes: Introduce uprobe_is_active()

2013-01-03 Thread Srikar Dronamraju
* Oleg Nesterov [2012-11-25 23:33:47]: > The lifetime of uprobe->rb_node and uprobe->inode is not refcounted, > delete_uprobe() is called when we detect that uprobe has no consumers, > and it would be deadly wrong to do this twice. > > Change delete_uprobe() to WARN() if it was already called. W

Re: [PATCH 2/3] uprobes: Introduce uprobe_is_active()

2013-01-02 Thread Anton Arapov
On Sun, Nov 25, 2012 at 11:33:47PM +0100, Oleg Nesterov wrote: > The lifetime of uprobe->rb_node and uprobe->inode is not refcounted, > delete_uprobe() is called when we detect that uprobe has no consumers, > and it would be deadly wrong to do this twice. > > Change delete_uprobe() to WARN() if it

[PATCH 2/3] uprobes: Introduce uprobe_is_active()

2012-11-25 Thread Oleg Nesterov
The lifetime of uprobe->rb_node and uprobe->inode is not refcounted, delete_uprobe() is called when we detect that uprobe has no consumers, and it would be deadly wrong to do this twice. Change delete_uprobe() to WARN() if it was already called. We use RB_CLEAR_NODE() to mark uprobe "inactive", th