Re: [PATCH 2/3] workqueue: use dedicated creater kthread for all pools

2014-07-28 Thread Tejun Heo
Hello, On Tue, Jul 29, 2014 at 09:26:35AM +0800, Lai Jiangshan wrote: > > It's a bit difficult to get excited about this patchset given that > > this is mostly churn without many actual benefits. Sure, it > > consolidates one-per-pool managers into one kthread_worker but it was > > one-per-pool a

Re: [PATCH 2/3] workqueue: use dedicated creater kthread for all pools

2014-07-28 Thread Lai Jiangshan
On 07/29/2014 02:55 AM, Tejun Heo wrote: > Hello, Lai. > > On Sat, Jul 26, 2014 at 11:04:50AM +0800, Lai Jiangshan wrote: >> There are some problems with the managers: >> 1) The last idle worker prefer managing to processing. >> It is better that the processing of work items should be the f

Re: [PATCH 2/3] workqueue: use dedicated creater kthread for all pools

2014-07-28 Thread Tejun Heo
Hello, Lai. On Sat, Jul 26, 2014 at 11:04:50AM +0800, Lai Jiangshan wrote: > There are some problems with the managers: > 1) The last idle worker prefer managing to processing. > It is better that the processing of work items should be the first > priority to make the whole system make

[PATCH 2/3] workqueue: use dedicated creater kthread for all pools

2014-07-25 Thread Lai Jiangshan
There are some problems with the managers: 1) The last idle worker prefer managing to processing. It is better that the processing of work items should be the first priority to make the whole system make progress earlier. 2) managers among different pools can be parallel, but actually