Re: [PATCH 2/3] x86/irq: factor out IS_ERR_OR_NULL check from platfom-specific handle_irq

On Sun, 4 Aug 2019, Heiner Kallweit wrote: > - > - if (!handle_irq(desc, regs)) { > + if (IS_ERR_OR_NULL(desc)) { This really want's an unlikely or preferrably be written as: if (likely(!IS_ERR_OR_NULL(desc))) { handle_irq(desc); } else { > a

[PATCH 2/3] x86/irq: factor out IS_ERR_OR_NULL check from platfom-specific handle_irq

The code can be simplified a little by factoring out the IS_ERR_OR_NULL check from the platform-specific handle_irq implementations. Signed-off-by: Heiner Kallweit --- arch/x86/include/asm/irq.h | 2 +- arch/x86/kernel/irq.c | 5 +++-- arch/x86/kernel/irq_32.c | 7 +-- arch/x86/kernel