Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding

2016-03-02 Thread Aravind Gopalakrishnan
On 3/2/2016 10:38 AM, Borislav Petkov wrote: But you can take the three here, merge them again into a single patch and do the changes ontot. I made them into three to show you more easily what should be changed. Ok, I'll just spin a V3 of the entire patchset with all your suggested changes

Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding

2016-03-02 Thread Borislav Petkov
On Wed, Mar 02, 2016 at 10:27:57AM -0600, Aravind Gopalakrishnan wrote: > So, have you pushed the set of patches you applied somewhere? (bp.git?) > I can work on top of those and it will be easier to rebase on top of tip.git > once the patches find their way there.. No. But you can take the three

Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding

2016-03-02 Thread Aravind Gopalakrishnan
On 3/2/2016 10:21 AM, Borislav Petkov wrote: On Wed, Mar 02, 2016 at 09:52:23AM -0600, Aravind Gopalakrishnan wrote: So, I think we should continue this approach and have something like this- static const char * const amd_core_mcablock_names[] = { [SMCA_LS] = "load_store",

Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding

2016-03-02 Thread Borislav Petkov
On Wed, Mar 02, 2016 at 09:52:23AM -0600, Aravind Gopalakrishnan wrote: > So, I think we should continue this approach and have something like this- > static const char * const amd_core_mcablock_names[] = { > [SMCA_LS] = "load_store", > [SMCA_IF] = "insn_fetch", >

Re: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding

2016-03-02 Thread Aravind Gopalakrishnan
On 3/2/2016 4:53 AM, Borislav Petkov wrote: Merge all IP blocks into a single enum. This allows for easier block name use later. Drop superfluous "_BLOCK" from the enum names. Signed-off-by: Borislav Petkov Cc: Aravind Gopalakrishnan enum amd_ip_types { - SMCA_F17H_CORE_BLOCK = 0,

[PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding

2016-03-02 Thread Borislav Petkov
From: Borislav Petkov Date: Wed, 2 Mar 2016 11:23:13 +0100 Subject: [PATCH 2/3] x86/mce/AMD, EDAC: Simplify SMCA decoding Merge all IP blocks into a single enum. This allows for easier block name use later. Drop superfluous "_BLOCK" from the enum names. Signed-off-by: Borislav