Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-30 Thread Borislav Petkov
On Tue, May 30, 2017 at 02:06:11PM +, Ghannam, Yazen wrote: > Okay, so I'll redo Patch 3 in this set and drop this one. Any comments on > Patch 1? Nope, I took it already. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-30 Thread Borislav Petkov
On Tue, May 30, 2017 at 02:06:11PM +, Ghannam, Yazen wrote: > Okay, so I'll redo Patch 3 in this set and drop this one. Any comments on > Patch 1? Nope, I took it already. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

RE: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-30 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, May 30, 2017 9:57 AM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; Tony Luck ; > x...@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH

RE: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-30 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, May 30, 2017 9:57 AM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; Tony Luck ; > x...@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for

Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-30 Thread Borislav Petkov
On Tue, May 30, 2017 at 12:39:03PM +, Ghannam, Yazen wrote: > Like I said in the commit message, the list_head needs to be outside the > list to access all the elements using list_for_each*. Otherwise, we won't > get a reference to the "head" element since we iterate starting from > head->next

Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-30 Thread Borislav Petkov
On Tue, May 30, 2017 at 12:39:03PM +, Ghannam, Yazen wrote: > Like I said in the commit message, the list_head needs to be outside the > list to access all the elements using list_for_each*. Otherwise, we won't > get a reference to the "head" element since we iterate starting from > head->next

RE: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-30 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Sunday, May 28, 2017 1:22 PM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; Borislav Petkov ; Tony Luck > ; x...@kernel.org;

RE: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-30 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Sunday, May 28, 2017 1:22 PM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; Borislav Petkov ; Tony Luck > ; x...@kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 2/3] x86/mce/AMD: Define a

Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-28 Thread Borislav Petkov
On Wed, May 24, 2017 at 03:41:46PM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > There needs to be a list_head outside of a linked list in order to iterate > over it and have access to all its elements. This is because the > list_for_each* macros iterate starting

Re: [PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-28 Thread Borislav Petkov
On Wed, May 24, 2017 at 03:41:46PM -0500, Yazen Ghannam wrote: > From: Yazen Ghannam > > There needs to be a list_head outside of a linked list in order to iterate > over it and have access to all its elements. This is because the > list_for_each* macros iterate starting from head->next rather

[PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-24 Thread Yazen Ghannam
From: Yazen Ghannam There needs to be a list_head outside of a linked list in order to iterate over it and have access to all its elements. This is because the list_for_each* macros iterate starting from head->next rather than head. Define a list_head for the threshold

[PATCH 2/3] x86/mce/AMD: Define a list_head for threshold blocks outside the list

2017-05-24 Thread Yazen Ghannam
From: Yazen Ghannam There needs to be a list_head outside of a linked list in order to iterate over it and have access to all its elements. This is because the list_for_each* macros iterate starting from head->next rather than head. Define a list_head for the threshold blocks list in struct