Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check

2016-05-04 Thread Wang YanQing
On Wed, May 04, 2016 at 08:35:24AM +0200, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > From: Wang YanQing > > > > We can't just break out when meet start is equal to zero, > > Hm, wot? > > Thanks, > > Ingo Sorry for my poor English ,and poor commit message, this bring trouble f

Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check

2016-05-04 Thread Matt Fleming
On Wed, 04 May, at 12:23:40PM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > On Wed, 04 May, at 08:35:24AM, Ingo Molnar wrote: > > > > > > * Matt Fleming wrote: > > > > > > > From: Wang YanQing > > > > > > > > We can't just break out when meet start is equal to zero, > > > > > > Hm, w

Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check

2016-05-04 Thread Ingo Molnar
* Matt Fleming wrote: > On Wed, 04 May, at 08:35:24AM, Ingo Molnar wrote: > > > > * Matt Fleming wrote: > > > > > From: Wang YanQing > > > > > > We can't just break out when meet start is equal to zero, > > > > Hm, wot? > > The existing code treats address 0x0 as invalid for a PCI BAR ran

Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check

2016-05-04 Thread Matt Fleming
On Wed, 04 May, at 08:35:24AM, Ingo Molnar wrote: > > * Matt Fleming wrote: > > > From: Wang YanQing > > > > We can't just break out when meet start is equal to zero, > > Hm, wot? The existing code treats address 0x0 as invalid for a PCI BAR range start address, but 0x0 is actually possible

Re: [PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check

2016-05-03 Thread Ingo Molnar
* Matt Fleming wrote: > From: Wang YanQing > > We can't just break out when meet start is equal to zero, Hm, wot? Thanks, Ingo

[PATCH 2/3] x86/sysfb_efi: Fix valid BAR address range check

2016-05-03 Thread Matt Fleming
From: Wang YanQing We can't just break out when meet start is equal to zero, this will cause us to miss valid address ranges in later BARs. On the other hand, it isn't enough to test start only for below situation: 0(start) <= lfb_base < end Due to the BUG this patch fix, I can't use video=e