Re: [PATCH 2/3] x86: remove duplicated parser for "pci=noacpi"

2006-12-06 Thread Yinghai Lu
so first hunk of the patch doesn't have nothing in common with second , and it is different disable acpi_irqs than disable all acpi, callacpi_disable_pci () is acpi=off. pci=noacpi mean it will not use acpi for pci bus scan and irq routing setting. acpi=noirq mean it will only not use irq

Re: [PATCH 2/3] x86: remove duplicated parser for "pci=noacpi"

2006-12-06 Thread Sergio Monteiro Basto
On Sun, 2006-11-26 at 15:23 -0800, Yinghai Lu wrote: [PATCH 2/3] x86: remove duplicated parser for "pci=noacpi" Remove "pci=noacpi" parse in acpi/boot.c, because it is duplicated with that in pci/common.c. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> diff --git a/ar

Re: [PATCH 2/3] x86: remove duplicated parser for pci=noacpi

2006-12-06 Thread Sergio Monteiro Basto
On Sun, 2006-11-26 at 15:23 -0800, Yinghai Lu wrote: [PATCH 2/3] x86: remove duplicated parser for pci=noacpi Remove pci=noacpi parse in acpi/boot.c, because it is duplicated with that in pci/common.c. Signed-off-by: Yinghai Lu [EMAIL PROTECTED] diff --git a/arch/i386/kernel/acpi/boot.c b

Re: [PATCH 2/3] x86: remove duplicated parser for pci=noacpi

2006-12-06 Thread Yinghai Lu
so first hunk of the patch doesn't have nothing in common with second , and it is different disable acpi_irqs than disable all acpi, callacpi_disable_pci () is acpi=off. pci=noacpi mean it will not use acpi for pci bus scan and irq routing setting. acpi=noirq mean it will only not use irq

RE: [PATCH 2/3] x86: remove duplicated parser for "pci=noacpi"

2006-11-27 Thread Lu, Yinghai
-Original Message- From: Andi Kleen [mailto:[EMAIL PROTECTED] Sent: Sunday, November 26, 2006 4:22 PM >Are you sure it's correct? The drivers/pci pci= parsing >isn't early and there tend to be nasty ordering issues. >I can't see where it would go wrong here, but it probably >needs very

RE: [PATCH 2/3] x86: remove duplicated parser for pci=noacpi

2006-11-27 Thread Lu, Yinghai
-Original Message- From: Andi Kleen [mailto:[EMAIL PROTECTED] Sent: Sunday, November 26, 2006 4:22 PM Are you sure it's correct? The drivers/pci pci= parsing isn't early and there tend to be nasty ordering issues. I can't see where it would go wrong here, but it probably needs very

Re: [PATCH 2/3] x86: remove duplicated parser for "pci=noacpi"

2006-11-26 Thread Yinghai Lu
On 27 Nov 2006 01:22:21 +0100, Andi Kleen <[EMAIL PROTECTED]> wrote: On Sun, Nov 26, 2006 at 03:23:36PM -0800, Yinghai Lu wrote: > Are you sure it's correct? The drivers/pci pci= parsing isn't early and there tend to be nasty ordering issues. I can't see where it would go wrong here, but it

Re: [PATCH 2/3] x86: remove duplicated parser for "pci=noacpi"

2006-11-26 Thread Andi Kleen
On Sun, Nov 26, 2006 at 03:23:36PM -0800, Yinghai Lu wrote: > Are you sure it's correct? The drivers/pci pci= parsing isn't early and there tend to be nasty ordering issues. I can't see where it would go wrong here, but it probably needs very careful double checking. -Andi - To unsubscribe from

[PATCH 2/3] x86: remove duplicated parser for "pci=noacpi"

2006-11-26 Thread Yinghai Lu
[PATCH 2/3] x86: remove duplicated parser for "pci=noacpi" Remove "pci=noacpi" parse in acpi/boot.c, because it is duplicated with that in pci/common.c. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel

[PATCH 2/3] x86: remove duplicated parser for pci=noacpi

2006-11-26 Thread Yinghai Lu
[PATCH 2/3] x86: remove duplicated parser for pci=noacpi Remove pci=noacpi parse in acpi/boot.c, because it is duplicated with that in pci/common.c. Signed-off-by: Yinghai Lu [EMAIL PROTECTED] diff --git a/arch/i386/kernel/acpi/boot.c b/arch/i386/kernel/acpi/boot.c index d12fb97..6d62dd1

Re: [PATCH 2/3] x86: remove duplicated parser for pci=noacpi

2006-11-26 Thread Andi Kleen
On Sun, Nov 26, 2006 at 03:23:36PM -0800, Yinghai Lu wrote: Are you sure it's correct? The drivers/pci pci= parsing isn't early and there tend to be nasty ordering issues. I can't see where it would go wrong here, but it probably needs very careful double checking. -Andi - To unsubscribe from

Re: [PATCH 2/3] x86: remove duplicated parser for pci=noacpi

2006-11-26 Thread Yinghai Lu
On 27 Nov 2006 01:22:21 +0100, Andi Kleen [EMAIL PROTECTED] wrote: On Sun, Nov 26, 2006 at 03:23:36PM -0800, Yinghai Lu wrote: Are you sure it's correct? The drivers/pci pci= parsing isn't early and there tend to be nasty ordering issues. I can't see where it would go wrong here, but it