RE: [PATCH 2/3] x86:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro

2018-05-29 Thread Nixiaoming
On 30 May 2018 at 2:07PM Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] wrote: >On 30 May 2018 at 07:58, Ingo Molnar wrote: >> >> * nixiaoming wrote: >> >>> mark_rodata_ro is only called by the function mark_readonly >>> when CONFIG_STRICT_KERNEL_RWX=y >>> >>> if CONFIG_STRICT_KERNEL_RWX is

Re: [PATCH 2/3] x86:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro

2018-05-29 Thread Ard Biesheuvel
On 30 May 2018 at 07:58, Ingo Molnar wrote: > > * nixiaoming wrote: > >> mark_rodata_ro is only called by the function mark_readonly >> when CONFIG_STRICT_KERNEL_RWX=y >> >> if CONFIG_STRICT_KERNEL_RWX is not set >> a compile warning may be triggered: unused function >> >> Signed-off-by: nixiaomi

Re: [PATCH 2/3] x86:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro

2018-05-29 Thread Ingo Molnar
* nixiaoming wrote: > mark_rodata_ro is only called by the function mark_readonly > when CONFIG_STRICT_KERNEL_RWX=y > > if CONFIG_STRICT_KERNEL_RWX is not set > a compile warning may be triggered: unused function > > Signed-off-by: nixiaoming > --- > arch/x86/mm/init_32.c | 2 ++ > arch/x86

[PATCH 2/3] x86:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro

2018-05-29 Thread nixiaoming
mark_rodata_ro is only called by the function mark_readonly when CONFIG_STRICT_KERNEL_RWX=y if CONFIG_STRICT_KERNEL_RWX is not set a compile warning may be triggered: unused function Signed-off-by: nixiaoming --- arch/x86/mm/init_32.c | 2 ++ arch/x86/mm/init_64.c | 2 ++ 2 files changed, 4 ins

[PATCH 2/3] x86:add missing CONFIG_STRICT_KERNEL_RWX for mark_rodata_ro

2018-05-27 Thread nixiaoming
Signed-off-by: nixiaoming --- arch/x86/mm/init_32.c | 2 ++ arch/x86/mm/init_64.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/x86/mm/init_32.c b/arch/x86/mm/init_32.c index c893c6a..121c567 100644 --- a/arch/x86/mm/init_32.c +++ b/arch/x86/mm/init_32.c @@ -920,6 +920,7 @@ static v