>
>> >> + if (cur) {
>> >> + if (!error)
>> >> + cur->bc_private.b.allocated = 0;
>> >
>> > Um, why?
>> Okay, will remove.
>
> I'm asking you to explain why you put it there. Don't remove code
> that might be necessary just because a hard question was asked
We copied thi
On Thu, Aug 01, 2013 at 02:33:09PM +0900, Namjae Jeon wrote:
> 2013/8/1, Dave Chinner :
> > On Wed, Jul 31, 2013 at 11:42:14PM +0900, Namjae Jeon wrote:
> >> From: Namjae Jeon
> >>
> >> New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS.
> >
> Hi Dave.
> > A good start, but there's
On Thu, Aug 01, 2013 at 01:24:02AM -0700, Christoph Hellwig wrote:
> Instead of adding more mess to change_file_space it might be a good idea
> to pull my
>
> "refactor the preallocation and hole punching code"
>
> series from December in first.
You mean this one:
http://oss.sgi.com/archives/
Instead of adding more mess to change_file_space it might be a good idea
to pull my
"refactor the preallocation and hole punching code"
series from December in first.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.or
2013/8/1, Ben Myers :
> Hey Namjae,
>
> On Wed, Jul 31, 2013 at 11:42:14PM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS.
>>
>> Signed-off-by: Namjae Jeon
>> Signed-off-by: Ashish Sangwan
>
Hi Ben.
> Very cool feature! ;)
2013/8/1, Dave Chinner :
> On Wed, Jul 31, 2013 at 11:42:14PM +0900, Namjae Jeon wrote:
>> From: Namjae Jeon
>>
>> New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS.
>
Hi Dave.
> A good start, but there's lots of work needed to make this safe for
> general use.
First, Thanks for y
On Wed, Jul 31, 2013 at 11:42:14PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon
>
> New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS.
A good start, but there's lots of work needed to make this safe for
general use.
> Signed-off-by: Namjae Jeon
> Signed-off-by: Ashish Sangwan
Hey Namjae,
On Wed, Jul 31, 2013 at 11:42:14PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon
>
> New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS.
>
> Signed-off-by: Namjae Jeon
> Signed-off-by: Ashish Sangwan
Very cool feature! ;)
I have a couple initial suggestions
From: Namjae Jeon
New fallocate flag FALLOC_FL_COLLAPSE_RANGE implementation for XFS.
Signed-off-by: Namjae Jeon
Signed-off-by: Ashish Sangwan
---
fs/xfs/xfs_bmap.c | 92 +
fs/xfs/xfs_bmap.h |3 ++
fs/xfs/xfs_file.c | 26
9 matches
Mail list logo
