Re: [PATCH 2/3 -mm] slub: use lib/hexdump

2007-05-30 Thread Randy Dunlap
On Wed, 30 May 2007 15:06:30 -0700 Randy Dunlap wrote: > Christoph Lameter wrote: > > I'd prefer something like this: > > > > Use hexdump in slub. > > Sure, that's fine. Just needs to #include > > Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> > > > > Index: slub/mm/slub.c > > ===

Re: [PATCH 2/3 -mm] slub: use lib/hexdump

2007-05-30 Thread Randy Dunlap
Christoph Lameter wrote: I'd prefer something like this: Use hexdump in slub. Sure, that's fine. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> Index: slub/mm/slub.c === --- slub.orig/mm/slub.c 2007-05-30 14:56:14.000

Re: [PATCH 2/3 -mm] slub: use lib/hexdump

2007-05-30 Thread Christoph Lameter
I'd prefer something like this: Use hexdump in slub. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> Index: slub/mm/slub.c === --- slub.orig/mm/slub.c 2007-05-30 14:56:14.0 -0700 +++ slub/mm/slub.c 2007-05-30 15:01

Re: [PATCH 2/3 -mm] slub: use lib/hexdump

2007-05-30 Thread Randy Dunlap
Christoph Lameter wrote: On Wed, 30 May 2007, Randy Dunlap wrote: I'd like to keep print_section around as it also does some other things. Repeating the output formatting at the various call locations will make it difficult to change if you add another whizbang feature. I have no problems with

Re: [PATCH 2/3 -mm] slub: use lib/hexdump

2007-05-30 Thread Christoph Lameter
On Wed, 30 May 2007, Randy Dunlap wrote: > > I'd like to keep print_section around as it also does some other things. > > Repeating the output formatting at the various call locations will make > > it difficult to change if you add another whizbang feature. > > I have no problems with keeping pri

Re: [PATCH 2/3 -mm] slub: use lib/hexdump

2007-05-30 Thread Randy Dunlap
Christoph Lameter wrote: On Wed, 30 May 2007, Randy Dunlap wrote: From: Randy Dunlap <[EMAIL PROTECTED]> Convert slub error memory dump functions to use lib/hexdump routines. Completely eliminate slub's print_section() function. I'd like to keep print_section around as it also does some othe

Re: [PATCH 2/3 -mm] slub: use lib/hexdump

2007-05-30 Thread Christoph Lameter
On Wed, 30 May 2007, Randy Dunlap wrote: > From: Randy Dunlap <[EMAIL PROTECTED]> > > Convert slub error memory dump functions to use lib/hexdump routines. > Completely eliminate slub's print_section() function. I'd like to keep print_section around as it also does some other things. Repeating

[PATCH 2/3 -mm] slub: use lib/hexdump

2007-05-30 Thread Randy Dunlap
From: Randy Dunlap <[EMAIL PROTECTED]> Convert slub error memory dump functions to use lib/hexdump routines. Completely eliminate slub's print_section() function. Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]> --- mm/slub.c | 53 - 1 file ch