On Wed, May 30, 2018 at 11:26:32AM +0200, Borislav Petkov wrote:
> > In "x86/mce: Exit properly when no banks to poll" you
> > leap right to the end. I'm wondering whether this can
> > ever happen? I mean, if there are no machine check banks,
> > then how did we get a machine check?
>
> Right, so
On Tue, May 29, 2018 at 11:54:25AM -0700, Luck, Tony wrote:
> Couple of thoughts:
Thanks for looking.
> In "x86/mce: Carve out bank scanning code" you drop the extra
> call to mce_severity() that I just added:
Yeah, did that before we talked about it.
> In "x86/mce: Exit properly when no banks
On Tue, May 29, 2018 at 11:54 AM, Luck, Tony wrote:
> On Tue, May 29, 2018 at 07:53:14PM +0200, Borislav Petkov wrote:
[..]
> P.S. What happened to my "part 3/3" (updating the Skylake quirk)
> ... does that belong in somebody else's tree?
I have no qualms taking it through the nvdimm tree with th
On Tue, May 29, 2018 at 07:53:14PM +0200, Borislav Petkov wrote:
> Nah, the cleanups will all go ontop. This is just a dirty branch to show
> my intention but yours go first and then the cleanup.
Couple of thoughts:
In "x86/mce: Carve out bank scanning code" you drop the extra
call to mce_severi
On Tue, May 29, 2018 at 05:50:48PM +, Luck, Tony wrote:
> Ah. That would be because I forgot to "git add" before "git commit --amend"
> :-(
Oh, I know the situation very well. :)
> I had put:
>
> (void) mce_severity(&m, cfg->tolerant, &msg, true);
>
> but either works.
Right
> It is still assigning.
Ah. That would be because I forgot to "git add" before "git commit --amend" :-(
> I'll simply do:
>
> if (worst >= MCE_PANIC_SEVERITY && mca_cfg.tolerant < 3) {
> mce_severity(&m, cfg->tolerant, &msg, true);
> mce_panic("Local fatal machi
On Tue, May 29, 2018 at 09:15:49AM -0700, Luck, Tony wrote:
> @@ -1287,12 +1292,17 @@ void do_machine_check(struct pt_regs *regs, long
> error_code)
> no_way_out = worst >= MCE_PANIC_SEVERITY;
> } else {
> /*
> - * Local MCE skipped calling mc
Some injection testing resulted in the following console log:
mce: [Hardware Error]: CPU 22: Machine Check Exception: f Bank 1:
bd8000100134
mce: [Hardware Error]: RIP 10: {pmem_do_bvec+0x11d/0x330
[nd_pmem]}
mce: [Hardware Error]: TSC c51a63035d52 ADDR 3234bc4000 MISC 88
mce: [Hardware
8 matches
Mail list logo
