Re: [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus

2016-12-05 Thread Takashi Sakamoto
On Dec 5 2016 16:32, Jiada Wang wrote: Hi Sakamoto On 11/30/2016 02:45 AM, Takashi Sakamoto wrote: Hi Jiada, I don't oppose this patch. Nevertheless, your description is not necessarily correct. On Nov 30 2016 16:59, Jiada Wang wrote: From: Daniel Girnus ALSA usually calls the prepare func

Re: [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus

2016-12-04 Thread Jiada Wang
Hi Sakamoto On 11/30/2016 02:45 AM, Takashi Sakamoto wrote: Hi Jiada, I don't oppose this patch. Nevertheless, your description is not necessarily correct. On Nov 30 2016 16:59, Jiada Wang wrote: From: Daniel Girnus ALSA usually calls the prepare function twice before starting the playba

Re: [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus

2016-11-30 Thread Jiada Wang
Hi Takashi On 11/30/2016 05:51 PM, Takashi Iwai wrote: On Wed, 30 Nov 2016 08:59:22 +0100, Jiada Wang wrote: From: Daniel Girnus ALSA usually calls the prepare function twice before starting the playback: 1. On hw_params call from userland and 2. internally when starting the stream. Some dev

Re: [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus

2016-11-30 Thread Takashi Sakamoto
On Nov 30 2016 19:45, Takashi Sakamoto wrote: Hi Jiada, I don't oppose this patch. Nevertheless, your description is not necessarily correct. On Nov 30 2016 16:59, Jiada Wang wrote: From: Daniel Girnus ALSA usually calls the prepare function twice before starting the playback: 1. On hw_param

Re: [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus

2016-11-30 Thread Takashi Sakamoto
Hi Jiada, I don't oppose this patch. Nevertheless, your description is not necessarily correct. On Nov 30 2016 16:59, Jiada Wang wrote: From: Daniel Girnus ALSA usually calls the prepare function twice before starting the playback: 1. On hw_params call from userland and 2. internally when s

Re: [PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus

2016-11-30 Thread Takashi Iwai
On Wed, 30 Nov 2016 08:59:22 +0100, Jiada Wang wrote: > > From: Daniel Girnus > > ALSA usually calls the prepare function twice before starting the playback: > 1. On hw_params call from userland and > 2. internally when starting the stream. > Some device are not able to manage this and they will

[PATCH 2/3 v2] ALSA: usb-audio: avoid setting of sample rate multiple times on bus

2016-11-30 Thread Jiada Wang
From: Daniel Girnus ALSA usually calls the prepare function twice before starting the playback: 1. On hw_params call from userland and 2. internally when starting the stream. Some device are not able to manage this and they will stop playback if the sample rate will be configured several times ov