Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-16 Thread Petr Mladek
On Fri 2015-11-13 10:59:34, Josh Poimboeuf wrote: > On Fri, Nov 13, 2015 at 02:54:42PM +0100, Petr Mladek wrote: > > On Thu 2015-11-12 13:19:17, Josh Poimboeuf wrote: > > > On Thu, Nov 12, 2015 at 03:31:58PM +0100, Petr Mladek wrote: > > > > On Wed 2015-11-11 11:57:31, Josh Poimboeuf wrote: > > > >

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-13 Thread Josh Poimboeuf
On Fri, Nov 13, 2015 at 02:54:42PM +0100, Petr Mladek wrote: > On Thu 2015-11-12 13:19:17, Josh Poimboeuf wrote: > > On Thu, Nov 12, 2015 at 03:31:58PM +0100, Petr Mladek wrote: > > > On Wed 2015-11-11 11:57:31, Josh Poimboeuf wrote: > > > > On Wed, Nov 11, 2015 at 10:29:00AM -0600, Chris J Arges w

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-13 Thread Petr Mladek
On Thu 2015-11-12 13:19:17, Josh Poimboeuf wrote: > On Thu, Nov 12, 2015 at 03:31:58PM +0100, Petr Mladek wrote: > > On Wed 2015-11-11 11:57:31, Josh Poimboeuf wrote: > > > On Wed, Nov 11, 2015 at 10:29:00AM -0600, Chris J Arges wrote: > > > > diff --git a/kernel/livepatch/core.c b/kernel/livepatch

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-12 Thread Josh Poimboeuf
On Thu, Nov 12, 2015 at 03:31:58PM +0100, Petr Mladek wrote: > On Wed 2015-11-11 11:57:31, Josh Poimboeuf wrote: > > On Wed, Nov 11, 2015 at 10:29:00AM -0600, Chris J Arges wrote: > > > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c > > > index 26f9778..4eb8691 100644 > > > --- a/ke

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-12 Thread Petr Mladek
On Wed 2015-11-11 11:57:31, Josh Poimboeuf wrote: > On Wed, Nov 11, 2015 at 10:29:00AM -0600, Chris J Arges wrote: > > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c > > index 26f9778..4eb8691 100644 > > --- a/kernel/livepatch/core.c > > +++ b/kernel/livepatch/core.c > > @@ -261,7 +

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-12 Thread Miroslav Benes
On Wed, 11 Nov 2015, Chris J Arges wrote: > In cases of duplicate symbols, sympos will be used to disambiguate instead > of val. By default old_sympos will be 0, and patching will only succeed if > the symbol is unique. Specifying a positive value will ensure that > occurrence of the symbol will b

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Josh Poimboeuf
On Wed, Nov 11, 2015 at 10:29:00AM -0600, Chris J Arges wrote: > In cases of duplicate symbols, sympos will be used to disambiguate instead > of val. By default old_sympos will be 0, and patching will only succeed if > the symbol is unique. Specifying a positive value will ensure that > occurrence

Re: [PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Chris J Arges
On 11/11/2015 10:29 AM, Chris J Arges wrote: > In cases of duplicate symbols, sympos will be used to disambiguate instead > of val. By default old_sympos will be 0, and patching will only succeed if Minor typo. old_sympos, should just be sympos. --chris > the symbol is unique. Specifying a positi

[PATCH 2/3 v4] livepatch: add old_sympos as disambiguator field to klp_reloc

2015-11-11 Thread Chris J Arges
In cases of duplicate symbols, sympos will be used to disambiguate instead of val. By default old_sympos will be 0, and patching will only succeed if the symbol is unique. Specifying a positive value will ensure that occurrence of the symbol will be used for patching if it is valid. Signed-off-by: