Re: [PATCH 2/4] ASoc: kirkwood: simplify probe error

2013-07-26 Thread Mark Brown
On Fri, Jul 26, 2013 at 08:28:18AM +0200, Jean-Francois Moine wrote: > Mark Brown wrote: > > This seems fine but doesn't apply against current code but otherwise > > seems fine. > My base is 3.11-rc2. Always submit against where the code will be applied - -next in this case. signature.asc Des

Re: [PATCH 2/4] ASoc: kirkwood: simplify probe error

2013-07-25 Thread Jean-Francois Moine
On Thu, 25 Jul 2013 20:10:59 +0100 Mark Brown wrote: > On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote: > > The function kirkwood_i2s_dev_remove() may be used when probe fails. > > This seems fine but doesn't apply against current code but otherwise > seems fine. My base is

Re: [PATCH 2/4] ASoc: kirkwood: simplify probe error

2013-07-25 Thread Mark Brown
On Thu, Jul 25, 2013 at 11:13:57AM +0200, Jean-Francois Moine wrote: > The function kirkwood_i2s_dev_remove() may be used when probe fails. This seems fine but doesn't apply against current code but otherwise seems fine. > + if (!IS_ERR(priv->extclk)) { > + clk_disable_unprepare(p

[PATCH 2/4] ASoc: kirkwood: simplify probe error

2013-07-25 Thread Jean-Francois Moine
The function kirkwood_i2s_dev_remove() may be used when probe fails. Signed-off-by: Jean-Francois Moine --- sound/soc/kirkwood/kirkwood-i2s.c | 44 +++ 1 file changed, 21 insertions(+), 23 deletions(-) diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/s