Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-19 Thread Henrik Rydberg
Hi Benson, > On Sat, Mar 16, 2013 at 1:00 PM, Henrik Rydberg wrote: > >> Userspace can initiate the firmware update procedure by copying cyapa.bin > >> to /lib/firmware, and then writing anything to the device sysfs attribute: > >> /sys/bus/i2c/devices/7-0067/update_fw > > > > Why do you need

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-19 Thread Henrik Rydberg
Hi Benson, On Sat, Mar 16, 2013 at 1:00 PM, Henrik Rydberg rydb...@euromail.se wrote: Userspace can initiate the firmware update procedure by copying cyapa.bin to /lib/firmware, and then writing anything to the device sysfs attribute: /sys/bus/i2c/devices/7-0067/update_fw Why do you

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-18 Thread Benson Leung
On Sat, Mar 16, 2013 at 1:00 PM, Henrik Rydberg wrote: >> Userspace can initiate the firmware update procedure by copying cyapa.bin >> to /lib/firmware, and then writing anything to the device sysfs attribute: >> /sys/bus/i2c/devices/7-0067/update_fw > > Why do you need to trigger this from

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-18 Thread Benson Leung
On Sat, Mar 16, 2013 at 1:00 PM, Henrik Rydberg rydb...@euromail.se wrote: Userspace can initiate the firmware update procedure by copying cyapa.bin to /lib/firmware, and then writing anything to the device sysfs attribute: /sys/bus/i2c/devices/7-0067/update_fw Why do you need to trigger

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-16 Thread Henrik Rydberg
Hi Benson, > From: Daniel Kurtz > > Use the kernel request_firmware API to allow a hotplug script to load new > firmware into CYAPA device. When request_firmware is called by a driver, > the kernel creates 'loading' and 'data' sysfs entries, and generates a > firmware udev event containing the

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-16 Thread Henrik Rydberg
Hi Benson, From: Daniel Kurtz djku...@chromium.org Use the kernel request_firmware API to allow a hotplug script to load new firmware into CYAPA device. When request_firmware is called by a driver, the kernel creates 'loading' and 'data' sysfs entries, and generates a firmware udev event

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-13 Thread Dmitry Torokhov
On Wed, Mar 13, 2013 at 04:50:49PM -0700, Benson Leung wrote: > + > +#define BYTE_PER_LINE 8 > +void cyapa_dump_data(struct cyapa *cyapa, size_t length, const u8 *data) > +{ > +#ifdef DEBUG > + struct device *dev = >client->dev; > + int i; > + char buf[BYTE_PER_LINE * 3 + 1]; > +

[PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-13 Thread Benson Leung
From: Daniel Kurtz Use the kernel request_firmware API to allow a hotplug script to load new firmware into CYAPA device. When request_firmware is called by a driver, the kernel creates 'loading' and 'data' sysfs entries, and generates a firmware udev event containing the name of a file

[PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-13 Thread Benson Leung
From: Daniel Kurtz djku...@chromium.org Use the kernel request_firmware API to allow a hotplug script to load new firmware into CYAPA device. When request_firmware is called by a driver, the kernel creates 'loading' and 'data' sysfs entries, and generates a firmware udev event containing the

Re: [PATCH 2/4] Input: cyapa - Firmware update via request firmware

2013-03-13 Thread Dmitry Torokhov
On Wed, Mar 13, 2013 at 04:50:49PM -0700, Benson Leung wrote: + +#define BYTE_PER_LINE 8 +void cyapa_dump_data(struct cyapa *cyapa, size_t length, const u8 *data) +{ +#ifdef DEBUG + struct device *dev = cyapa-client-dev; + int i; + char buf[BYTE_PER_LINE * 3 + 1]; + char