Re: [PATCH 2/4] KVM: nVMX: Handle dynamic MSR intercept toggling

2021-03-17 Thread Sean Christopherson
On Wed, Mar 17, 2021, Sean Christopherson wrote: > On Wed, Mar 17, 2021, Paolo Bonzini wrote: > > On 17/03/21 17:50, Sean Christopherson wrote: > > > > Feel free to squash patch 3 in this one or reorder it before; it makes > > > > sense > > > > to make them macros when you go from 4 to 6

Re: [PATCH 2/4] KVM: nVMX: Handle dynamic MSR intercept toggling

2021-03-17 Thread Sean Christopherson
On Wed, Mar 17, 2021, Paolo Bonzini wrote: > On 17/03/21 17:50, Sean Christopherson wrote: > > > Feel free to squash patch 3 in this one or reorder it before; it makes > > > sense > > > to make them macros when you go from 4 to 6 functions. > > I put them in a separate patch so that backporting

Re: [PATCH 2/4] KVM: nVMX: Handle dynamic MSR intercept toggling

2021-03-17 Thread Paolo Bonzini
On 17/03/21 17:50, Sean Christopherson wrote: Feel free to squash patch 3 in this one or reorder it before; it makes sense to make them macros when you go from 4 to 6 functions. I put them in a separate patch so that backporting the fix for the older FS/GS nVMX bug was at least feasible. Not

Re: [PATCH 2/4] KVM: nVMX: Handle dynamic MSR intercept toggling

2021-03-17 Thread Sean Christopherson
On Wed, Mar 17, 2021, Paolo Bonzini wrote: > On 16/03/21 19:44, Sean Christopherson wrote: > > Always check vmcs01's MSR bitmap when merging L0 and L1 bitmaps for L2, > > and always update the relevant bits in vmcs02. This fixes two distinct, > > but intertwined bugs related to dynamic MSR bitmap

Re: [PATCH 2/4] KVM: nVMX: Handle dynamic MSR intercept toggling

2021-03-17 Thread Paolo Bonzini
On 16/03/21 19:44, Sean Christopherson wrote: Always check vmcs01's MSR bitmap when merging L0 and L1 bitmaps for L2, and always update the relevant bits in vmcs02. This fixes two distinct, but intertwined bugs related to dynamic MSR bitmap modifications. The first issue is that KVM fails to

[PATCH 2/4] KVM: nVMX: Handle dynamic MSR intercept toggling

2021-03-16 Thread Sean Christopherson
Always check vmcs01's MSR bitmap when merging L0 and L1 bitmaps for L2, and always update the relevant bits in vmcs02. This fixes two distinct, but intertwined bugs related to dynamic MSR bitmap modifications. The first issue is that KVM fails to enable MSR interception in vmcs02 for the FS/GS