Re: [PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-03 Thread Mark Brown
On Tue, Dec 03, 2013 at 12:13:23PM +0530, Keerthy wrote: > +static struct regmap_config tps65218_regmap_config = { > + .reg_bits = 8, > + .val_bits = 8, > +}; You should consider using a register cache for at least the interrupt mask registers, it'll improve performance. signature.asc D

Re: [PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-03 Thread Mark Brown
On Tue, Dec 03, 2013 at 11:21:07AM +, Lee Jones wrote: > other is that you shouldn't be doing this at all with regulators. Mark > likes the idea of having a single regulator controller node which > contains all of these individual regulator sub-nodes and you initiate > a single call to for_eac

Re: [PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-03 Thread Lee Jones
> >>+ ret = of_platform_populate(client->dev.of_node, NULL, NULL, > >>+ &client->dev); > >What are you trying to do here? > > > >Register each regulator as a platform device? > > Yeah. The probe will be called for every regulator separately. So there are two schools

Re: [PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-03 Thread Keerthy
On Tuesday 03 December 2013 02:54 PM, Lee Jones wrote: The TPS65218 chip is a power management IC for Portable Navigation Systems and Tablet Computing devices. It contains the following components: - Regulators. - Over Temperature warning and Shut down. This patch adds support for tps65218

Re: [PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-03 Thread Lee Jones
> The TPS65218 chip is a power management IC for Portable Navigation Systems > and Tablet Computing devices. It contains the following components: > > - Regulators. > - Over Temperature warning and Shut down. > > This patch adds support for tps65218 mfd device. At this time only > the regulator

[PATCH 2/4] MFD: TPS65218: Add driver for the TPS65218 PMIC

2013-12-02 Thread Keerthy
The TPS65218 chip is a power management IC for Portable Navigation Systems and Tablet Computing devices. It contains the following components: - Regulators. - Over Temperature warning and Shut down. This patch adds support for tps65218 mfd device. At this time only the regulator functionality i