Re: [PATCH 2/4] fix not-and/or errors

2007-10-17 Thread Peter Zijlstra
On Wed, 2007-10-17 at 15:49 +0200, Roel Kluin wrote: > if(!x & y) should either be if(!(x & y)) or if(!x && y) > I made changes as seemed appropriate, but please review > > several changes to drivers/net/ > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> likewise - To

Re: [PATCH 2/4] fix not-and/or errors

2007-10-17 Thread Roel Kluin
Roel Kluin wrote: > if(!x & y) should either be if(!(x & y)) or if(!x && y) > I made changes as seemed appropriate, but please review > > several changes to drivers/net/ > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > hmmm forgot to place '---' here, should I resend?

[PATCH 2/4] fix not-and/or errors

2007-10-17 Thread Roel Kluin
if(!x & y) should either be if(!(x & y)) or if(!x && y) I made changes as seemed appropriate, but please review several changes to drivers/net/ Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c index

Re: [PATCH 2/4] fix not-and/or errors

2007-10-17 Thread Roel Kluin
Roel Kluin wrote: if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review several changes to drivers/net/ Signed-off-by: Roel Kluin [EMAIL PROTECTED] hmmm forgot to place '---' here, should I resend? diff --git

Re: [PATCH 2/4] fix not-and/or errors

2007-10-17 Thread Peter Zijlstra
On Wed, 2007-10-17 at 15:49 +0200, Roel Kluin wrote: if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review several changes to drivers/net/ Signed-off-by: Roel Kluin [EMAIL PROTECTED] likewise - To unsubscribe from

[PATCH 2/4] fix not-and/or errors

2007-10-17 Thread Roel Kluin
if(!x y) should either be if(!(x y)) or if(!x y) I made changes as seemed appropriate, but please review several changes to drivers/net/ Signed-off-by: Roel Kluin [EMAIL PROTECTED] diff --git a/drivers/net/e1000e/82571.c b/drivers/net/e1000e/82571.c index