Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-06 Thread Paul Gortmaker
On Fri, Aug 5, 2016 at 10:55 AM, Thomas Petazzoni wrote: > The Marvell Armada 7K/8K integrates a secondary interrupt controller > very originally named "PIC". It is connected to the main GIC via a > PPI. Amongst other things, this PIC is used for the ARM PMU.

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-06 Thread Paul Gortmaker
On Fri, Aug 5, 2016 at 10:55 AM, Thomas Petazzoni wrote: > The Marvell Armada 7K/8K integrates a secondary interrupt controller > very originally named "PIC". It is connected to the main GIC via a > PPI. Amongst other things, this PIC is used for the ARM PMU. > > This commit adds a simple irqchip

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-06 Thread Paul Gortmaker
On Fri, Aug 5, 2016 at 7:00 PM, Paul Gortmaker wrote: >> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig >> index fa33c50..a6f90c5 100644 >> --- a/drivers/irqchip/Kconfig >> +++ b/drivers/irqchip/Kconfig >> @@ -246,6 +246,9 @@ config MVEBU_ODMI >>

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-06 Thread Paul Gortmaker
On Fri, Aug 5, 2016 at 7:00 PM, Paul Gortmaker wrote: >> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig >> index fa33c50..a6f90c5 100644 >> --- a/drivers/irqchip/Kconfig >> +++ b/drivers/irqchip/Kconfig >> @@ -246,6 +246,9 @@ config MVEBU_ODMI >> bool >> select

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Jason Cooper
Hi Thomas, On Fri, Aug 05, 2016 at 05:58:12PM +0200, Thomas Petazzoni wrote: > On Fri, 5 Aug 2016 15:31:13 +, Jason Cooper wrote: > > > > +config MVEBU_PIC > > > + bool > > > > tri-state? Is there anything else attached to the PIC besides the PMU? > > tri-state would be fine I believe,

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Jason Cooper
Hi Thomas, On Fri, Aug 05, 2016 at 05:58:12PM +0200, Thomas Petazzoni wrote: > On Fri, 5 Aug 2016 15:31:13 +, Jason Cooper wrote: > > > > +config MVEBU_PIC > > > + bool > > > > tri-state? Is there anything else attached to the PIC besides the PMU? > > tri-state would be fine I believe,

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Thomas Petazzoni
Hello, Thanks for the quick feedback! On Fri, 5 Aug 2016 15:31:13 +, Jason Cooper wrote: > > +config MVEBU_PIC > > + bool > > tri-state? Is there anything else attached to the PIC besides the PMU? tri-state would be fine I believe, it's indeed a secondary interrupt controller, not

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Thomas Petazzoni
Hello, Thanks for the quick feedback! On Fri, 5 Aug 2016 15:31:13 +, Jason Cooper wrote: > > +config MVEBU_PIC > > + bool > > tri-state? Is there anything else attached to the PIC besides the PMU? tri-state would be fine I believe, it's indeed a secondary interrupt controller, not

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Jason Cooper
Hi Thomas, On Fri, Aug 05, 2016 at 04:55:19PM +0200, Thomas Petazzoni wrote: > The Marvell Armada 7K/8K integrates a secondary interrupt controller > very originally named "PIC". It is connected to the main GIC via a > PPI. Amongst other things, this PIC is used for the ARM PMU. > > This commit

Re: [PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Jason Cooper
Hi Thomas, On Fri, Aug 05, 2016 at 04:55:19PM +0200, Thomas Petazzoni wrote: > The Marvell Armada 7K/8K integrates a secondary interrupt controller > very originally named "PIC". It is connected to the main GIC via a > PPI. Amongst other things, this PIC is used for the ARM PMU. > > This commit

[PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Thomas Petazzoni
The Marvell Armada 7K/8K integrates a secondary interrupt controller very originally named "PIC". It is connected to the main GIC via a PPI. Amongst other things, this PIC is used for the ARM PMU. This commit adds a simple irqchip driver for this interrupt controller. Since this interrupt

[PATCH 2/4] irqchip: irq-mvebu-pic: new driver for Marvell Armada 7K/8K PIC

2016-08-05 Thread Thomas Petazzoni
The Marvell Armada 7K/8K integrates a secondary interrupt controller very originally named "PIC". It is connected to the main GIC via a PPI. Amongst other things, this PIC is used for the ARM PMU. This commit adds a simple irqchip driver for this interrupt controller. Since this interrupt