Hello,
On Thu, Mar 14, 2019 at 11:15:28AM +0100, Pavel Machek wrote:
> On Thu 2019-03-14 10:31:11, Uwe Kleine-König wrote:
> 1;2802;0c> Hello,
> >
> > On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote:
> > > +static void set_device(struct led_netdev_data *trigger_data,
> > > +
On Thu 2019-03-14 10:31:11, Uwe Kleine-König wrote:
1;2802;0c> Hello,
>
> On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote:
> > +static void set_device(struct led_netdev_data *trigger_data,
> > + const char *buf, size_t size)
>
> "set_device" is a very generic
On 14/03/2019 10.31, Uwe Kleine-König wrote:
> Hello,
>
> On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote:
>> +static void set_device(struct led_netdev_data *trigger_data,
>> + const char *buf, size_t size)
>
> "set_device" is a very generic name. Can you
Hello,
On Wed, Mar 13, 2019 at 09:26:13PM +0100, Rasmus Villemoes wrote:
> +static void set_device(struct led_netdev_data *trigger_data,
> +const char *buf, size_t size)
"set_device" is a very generic name. Can you please prefix it with
"ledtrig_netdev_"?
Best regards
Uwe
Take the part of device_name_store that puts the old device (if any),
copies the new device name, looks the name up etc. into a separate
helper function. This is preparation for using that helper from a
function that will initialize the led_netdev_data from a device tree
node. No functional
5 matches
Mail list logo
